GNOME Bugzilla – Bug 73585
theme changes are not being honoured
Last modified: 2009-08-15 18:40:50 UTC
There is not way of applying changes made through the Theme Selector CApplet.
And no other method is available so marking up to Urgent. As usual, if this is someone not running gnome2-settings-daemon, please close.
gnome2-settings-daemon is running
Lauris, can you look at this?
Works for me. Which themes you are trying with? Do they otherwise work well? Are theme setting values persisten between gnomecc (theme capplet) sessions? Any warning/debug messages from capplet and or settings daeomn?
sorry for lack of detail in above reports: started the gnome2-settings-daemon before attempting to change theme (with Gtk+ them selector). For each of the installed themes (Default, Metal & Redmond65) an error message was displayed in terminal: "setting Net/ThemeName Default Invalid XSETTINGS property (read off end) setting Net/ThemeName Metal Invalid XSETTINGS property (read off end) setting Net/ThemeName Redmond65 Invalid XSETTINGS property (read off end)" Same error is displayed when running through dbx.
Is it possible, that this is related and/or duplicate of 71150? Dave, does it work for you on sparc/solaris?
This bug has regressed. gtk+ theme selector capplet that shipped with Beta2: in addition to not (instant) applying changes to the current gnome theme it will not allow a user to preview a theme. The 'Preview' button and the checkbox for automatic preview are not present - I have logged a new bug (bugid: 74624) against this.
*** Bug 74624 has been marked as a duplicate of this bug. ***
The preview button is gone, because it should now be true instant apply (and is for me). Dave, can you check, whether it works on your sun machine?
My sun machine doesn't have gnome on it yet. Shane, the summary says "... not instant apply", does that imply that it is applying, but not instantly? Or is the setting not applying at all? I'm inclined to change the summary of this bug to "gtk xsettings do not apply on solaris." Would this be accurate?
the settings do not apply at all - in addtion to this the preview does not work -
In beta3 the gnome2-settings-daemon is crashes after desktop login and everytime you try to start it - see bugid:77775. Cannot apply any changes for the Gtk+ theme editor without the gnome2-settings-daemon.
Updating all cc bugs that have the GNOME2 keyword set to the GNOME2.0 milestone, to help jrb triage/prioritize cc bugs. Filter on 'luis doing GNOME2 work' to ignore this spam.
the gnome-settings-daemon crash has been fixed. there's a new font/theme capplet in CVS, and when running it on my solaris workstation i do get the 'Invalid XSETTINGS property (read off end)' messages, which i believe are inhibitting the theme change to take effect. is this a correct assessment?
fixed in CVS gtk+ and sun-patches: 2002-04-12 jacob berkman <jacob@ximian.com> * gdk/x11/xsettings-client.c (fetch_card8): fix cut-n-paste bug which breaks big-endian machines (fixes #73585)
Jacob, this is correct - I've installed a nightly from 17th April and when trying to change the theme am getting the "Invalid XSETTINGS property (read off end)" messages and no theme changes are getting applied. I've also noted that the Font changes are not applied and I get errors such as: "(/opt/gnome-2.0/bin/gnome-font-and-theme-properties:10254): Gtk-CRITICAL **: file gtktreemodel.c: line 333: assertion `path != NULL' failed vi E(gnome-font-and-theme-properties:10223): Gtk-CRITICAL **: file gtkliststore.c: line 571: assertion `GTK_LIST_STORE (tree_model)->stamp == iter->stamp' failed" This is same when run through dbx.
if you *are* getting "Invalid XSETTINGS property (read off end)" then you aren't getting the fix for this. which gtk are you using? which branch, built by whom etc? specifically, if you are using the multihead branch it may not be in that. i am 99% certain it is fixed as i could reproduce your problem exactly until i fixed it.
i'm using gtk+ 2.0.2 dated april 17th:- "cvs -q co -D 'Wed Apr 17 01:26:00 BST 2002' gtk+" Your fix is listed in the Change Log:- "2002-04-12 jacob berkman <jacob@ximian.com> * gdk/x11/xsettings-client.c (fetch_card8): fix cut-n-paste bug which breaks big-endian machines (fixes #73585)" Let me know if I can I check anything else?
I can not replicate any of those warnings with current CVS on linux.
jody, it was an endianess bug not an OS specific one. people were getting it on ppc linux too. i am installing the latest gtk2 build and will retry with current CVS theme switcher and settings daemon.
ok, theme switching still works for me. what themes are you trying to switch between?
so it looks like its fixed in the latest gtk from cvs? i'll update gtk on my system and check this.
I just updated gtk+ to a that taken from cvs at 1am April 19th - I am still seeing the above mentioned error messages when changing theme with the Gtk+ theme selector capplet. I am switching between all the available themes - Default -> Redmond95 -> Metal. Font changes are also not being implemented - see above for more info. Is there anything else I should have updated when updating Gtk+?
ok, i'll build those themes (i was just testing with a short gtkrc which made text red). just for fun, can you double check that what you're running links against the gtk that you've built? (ldd `which gnome-font-and-theme-properties` | grep gtk) [ the binary name might be different - i guessed from memory ]
i checked for links and the following is there: "libgtk-x11-2.0.so.0 => /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0"
i am taking ownership as this seems to be solaris specific
ok, i just tested and there was a bug in the metal theme that would crash with notebook tabs. fixed in CVS. however, i still do not get the XSETTINGS message, and theme switches work fine. can you double check - in gtk+/gdk, do a make clean, then build, then reinstall (and verify that it goes into the right place). also verify that you get this: acob@wet-pants:gtk+ G2$ cvs status gdk/x11/xsettings-client.c =================================================================== File: xsettings-client.c Status: Up-to-date Working revision: 1.2 Repository revision: 1.2 /cvs/gnome/gtk+/gdk/x11/xsettings-client.c,v Sticky Tag: (none) Sticky Date: (none) Sticky Options: (none)
also font changes work for me.
*** Bug 80216 has been marked as a duplicate of this bug. ***
i am still seeing this - do i need to re-login for changes to take effect? In beta4 I changing betweem Default, Metal, Redmond95 themes does nothing - also changing fonts for Application or Desktop does nothing. I've tried turning off the 'Use Nautilus to draw desktop' option and this makes no differenc.
did you check that you had the right version of xsettings-client.c?
hiya jacob, how do i know what the right version of xsettings-client.c is?
as i said above: > also verify that you get this: > > acob@wet-pants:gtk+ G2$ cvs status gdk/x11/xsettings-client.c > =================================================================== > File: xsettings-client.c Status: Up-to-date > > Working revision: 1.2 > Repository revision: 1.2 /cvs/gnome/gtk+/gdk/x11/xsettings-client.c,v > Sticky Tag: (none) > Sticky Date: (none) > Sticky Options: (none)
It works okay for me on Linux/PPC (Debian Woody), with a vicious build scripts build from 29/4/2002 (morning GMT)
have you logged out/in since installing the gtk which i said had the fix? you may need to restart gnome-settings daemon.
I have gtk+ 2.0.2 + jacob's endian patch and control-center 1.99.6-1 running on Debian/PPC with X4.2, and the theme switcher work just fine for me. All the changes are instant-apply.
Shane, Keelin: what is the situation here?
as it stands it's still not working BUT I'm going to have another look today
*** Bug 72576 has been marked as a duplicate of this bug. ***
Shane - did you manage to reproduce it? We're still seeing it working here.
I've tried again with source from the 5th of May and themes are still not being applied on Solaris. The capplet runs fine and you can select between the 3 available themes but there are no changes applied. I am moving between Default, Metal & Redmond95. There is not much available via debug - am I missing something, is there a flag that needs to be set somewhere (some other sawfish capplet?) to allow theme changes? Am attaching a file with truss output when trying to change themes.
Created attachment 8252 [details] truss output when changing themes
the truss output isn't useful. you also never verified that you had the required xsettings-client.c. please apply the patch i'm about to attach, and verify that when you run apps, you get a "Opening display..." message printed out.
Created attachment 8255 [details] [review] patch to print a message at startup.
not sure how to apply patches but i'll checkout the gtk+ source and talk to the sun build guys.
as per feedback from sun developers, this bug is definitely fixed. shane, it must be some misconfiguration on your system with library paths or something. everyone else can confirm that this is working now.
yea - its working for me too... cheers jacob verifying fixed in source from 13th may
closing