After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731122 - Only show the location menu when apps are using location services
Only show the location menu when apps are using location services
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.13.x
Other Linux
: Normal normal
: 3.14
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 731119
Blocks:
 
 
Reported: 2014-06-02 18:15 UTC by Allan Day
Modified: 2014-08-19 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
location: Only show menu when geolocation is in use (1.09 KB, patch)
2014-08-09 15:40 UTC, Zeeshan Ali
committed Details | Review

Description Allan Day 2014-06-02 18:15:46 UTC
Currently, we always show the location submenu. This is problematic, because it looks like location services are in use when they are not (see bug 730156). It also unnecessarily clutters the system menu.

The location menu is essentially there to let you control privacy. I think the general approach we want to take for privacy features is to show a status icon (and corresponding menu) when the feature is being used by applications (since it is with apps that privacy is a factor - we should be able to trust the system to use privacy sensitive features appropriately).

As such, we should only show the location menu when applications are using location services. This requires that we first have a location settings that allows someone to:

 * disable location services
 * identify which apps are using them
 * black list apps from using them

This is covered by bug 731119.
Comment 1 Zeeshan Ali 2014-07-31 12:57:47 UTC
(In reply to comment #0)
> Currently, we always show the location submenu. This is problematic, because it
> looks like location services are in use when they are not (see bug 730156). It
> also unnecessarily clutters the system menu.
> 
> The location menu is essentially there to let you control privacy. I think the
> general approach we want to take for privacy features is to show a status icon
> (and corresponding menu) when the feature is being used by applications (since
> it is with apps that privacy is a factor - we should be able to trust the
> system to use privacy sensitive features appropriately).
> 
> As such, we should only show the location menu when applications are using
> location services. This requires that we first have a location settings that
> allows someone to:
> 
>  * disable location services
>  * identify which apps are using them
>  * black list apps from using them

Do we really need the last two for this bug?
Comment 2 Bastien Nocera 2014-08-05 10:51:28 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > Currently, we always show the location submenu. This is problematic, because it
> > looks like location services are in use when they are not (see bug 730156). It
> > also unnecessarily clutters the system menu.
> > 
> > The location menu is essentially there to let you control privacy. I think the
> > general approach we want to take for privacy features is to show a status icon
> > (and corresponding menu) when the feature is being used by applications (since
> > it is with apps that privacy is a factor - we should be able to trust the
> > system to use privacy sensitive features appropriately).
> > 
> > As such, we should only show the location menu when applications are using
> > location services. This requires that we first have a location settings that
> > allows someone to:
> > 
> >  * disable location services
> >  * identify which apps are using them
> >  * black list apps from using them
> 
> Do we really need the last two for this bug?

Those last 2 should live in gnome-control-center's Settings panel.
Comment 3 Allan Day 2014-08-06 18:33:54 UTC
(In reply to comment #2)
...
> > >  * disable location services
> > >  * identify which apps are using them
> > >  * black list apps from using them
> > 
> > Do we really need the last two for this bug?
> 
> Those last 2 should live in gnome-control-center's Settings panel.

Indeed, and it's not strictly required in order to fix this. The main thing we need is a switch in gnome-control-center which allows you to turn off location settings. Once that's in place, we no longer need to show the shell location sub-menu all the time.
Comment 4 Zeeshan Ali 2014-08-09 15:40:54 UTC
Created attachment 283011 [details] [review]
location: Only show menu when geolocation is in use

Users can now toggle geolocation off/on from privacy panel of
gnome-control-center so we don't need to clutter the menu with a
settings that most users won't touch most of the time.
Comment 5 Jasper St. Pierre (not reading bugmail) 2014-08-09 15:47:25 UTC
Review of attachment 283011 [details] [review]:

Fine by me.
Comment 6 Zeeshan Ali 2014-08-19 18:24:33 UTC
Attachment 283011 [details] pushed as 5b624a3 - location: Only show menu when geolocation is in use