GNOME Bugzilla – Bug 730896
geocode-glib installs icons in the gnome icon theme
Last modified: 2019-03-20 10:39:15 UTC
geocode-glib currently installs its mime type icons in the gnome icon theme directories. The gnome icon theme is going away in 3.14 and is being replaced by the Adwaita icon theme. According to mclasen, those geocode-glib icons should go in a private icon theme extension instead. /usr/share/icons/gnome/scalable/places/poi-airport.svg /usr/share/icons/gnome/scalable/places/poi-building.svg /usr/share/icons/gnome/scalable/places/poi-bus-stop.svg /usr/share/icons/gnome/scalable/places/poi-car.svg /usr/share/icons/gnome/scalable/places/poi-marker.svg /usr/share/icons/gnome/scalable/places/poi-railway-station.svg /usr/share/icons/gnome/scalable/places/poi-town.svg
Arr, I copied the text too eagerly from another bug report; please ignore the part where I claim that these are mime type icons :)
Hi, Thanks for reporting this. So where should they go? /usr/share/icons/hicolor/scalable/places/ ?
Where are they used anyway? gnome-maps? Can't they go there instead?
(In reply to comment #3) > Where are they used anyway? gnome-maps? Can't they go there instead? I think that makes sense, or do we have any designs for apps where we'd want to do a geocode request and also show icons except for Maps?
(In reply to comment #4) > (In reply to comment #3) > > Where are they used anyway? gnome-maps? Can't they go there instead? > > I think that makes sense, or do we have any designs for apps where we'd want to > do a geocode request and also show icons except for Maps? Yes, it sounds good but we have a get_icon method on GeocodePlace. That needs to return something. So icon need to be present, right? Should the icons be a meta-package that both Maps and Geocode-glib relies on while depracating/removing the get_icon? Or is there a clearer way out?
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Where are they used anyway? gnome-maps? Can't they go there instead? > > > > I think that makes sense, or do we have any designs for apps where we'd want to > > do a geocode request and also show icons except for Maps? > > Yes, it sounds good but we have a get_icon method on GeocodePlace. That needs > to return something. So icon need to be present, right? > > Should the icons be a meta-package that both Maps and Geocode-glib relies on > while depracating/removing the get_icon? > > Or is there a clearer way out? Or if Maps is the only user maybe just straight deprecate GeocodePlace::get_icon and have it return NULL?
Ping.
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > Where are they used anyway? gnome-maps? Can't they go there instead? > > > > > > I think that makes sense, or do we have any designs for apps where we'd want to > > > do a geocode request and also show icons except for Maps? > > > > Yes, it sounds good but we have a get_icon method on GeocodePlace. That needs > > to return something. So icon need to be present, right? > > > > Should the icons be a meta-package that both Maps and Geocode-glib relies on > > while depracating/removing the get_icon? > > > > Or is there a clearer way out? > > Or if Maps is the only user maybe just straight deprecate > GeocodePlace::get_icon and have it return NULL? Sure.
Created attachment 283159 [details] [review] Stop supplying icons for GeocodePlace Something like this maybe?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/geocode-glib/issues/12.