After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729812 - Stop/Reload button should be always visible.
Stop/Reload button should be always visible.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
3.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 725191 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-05-08 12:49 UTC by Carlos Alberto Lopez Perez
Modified: 2014-08-10 08:49 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
ephy-window: Move the reload button to the header bar (4.27 KB, patch)
2014-05-08 13:21 UTC, Yosef Or Boczko
reviewed Details | Review
ephy-window: Move the reload button to the header bar (4.21 KB, patch)
2014-05-20 09:42 UTC, Yosef Or Boczko
none Details | Review
Screenshot - the reload button in the navigation box (242.70 KB, image/png)
2014-05-20 09:43 UTC, Yosef Or Boczko
  Details
ephy-window: Move the reload button to the header bar (4.70 KB, patch)
2014-06-11 17:52 UTC, Yosef Or Boczko
reviewed Details | Review
Screenshot - the reload button linked to the navigation buttons (228.47 KB, image/png)
2014-07-07 17:37 UTC, Yosef Or Boczko
  Details
Screenshot - the reload button not linked to the navigation buttons (191.62 KB, image/png)
2014-07-07 17:37 UTC, Yosef Or Boczko
  Details
Screenshot - the reload button between the back and the forward buttons (194.96 KB, image/png)
2014-07-07 18:10 UTC, Yosef Or Boczko
  Details
ephy-window: Move the reload button to the header bar (4.54 KB, patch)
2014-08-10 07:38 UTC, Yosef Or Boczko
committed Details | Review

Description Carlos Alberto Lopez Perez 2014-05-08 12:49:28 UTC
Hi,

Epiphany 3.12 hides the Stop/Reload button. You can only see it when you click on the URL bar and the focus is on the URL text.

I think that this is a bit confusing. I was looking for the stop/reload button and I was unable to find it (after asking, a college told me that I should first click on the URL bar).

I also think this is inconvenient, because you have to do two clicks/touchs for a very common task (stop or reload the current page).

According to the FireFox Heatmap (a study based on over 117,000 submissions) the Reload button is used by 71% of users, with an average of 17.24 clicks per user. And the Stop button is used by 41% of users, with an average of 2.3 clicks per user.

The Reload button is the 5th element on importance of the browser UI for the average user.

https://heatmap.mozillalabs.com/

Based on this data, I think that the Stop/Reload button should be always visible.

Thanks
Comment 1 Yosef Or Boczko 2014-05-08 13:09:31 UTC
I see here only two options - to move the reload/stop button to the header bar,
or to leave it in the search/entry/address bar.

I think we have some discussions on this already, and we decided to leave the reload/stop
button in the entry bar.
Comment 2 Adrian Perez 2014-05-08 13:10:38 UTC
Personally, I also find it little intuitive that the button is only
displayed after clicking in the URL to make the entry active. It is
certainly not as discoverable as it would be to always show the button.

Also, when Ephy is opened in application mode, the Stop/Reload button
is always visible. Making the button always visible in normal browser
mode would make both experiences more coherent.
Comment 3 Yosef Or Boczko 2014-05-08 13:14:04 UTC
I just want to noice the fact the reload button displayed when you open a new
tab and start to loading page (before the page finish loading), so in the time the
page still in loading, the user can to click on the stop button to stop the loading.
Comment 4 Yosef Or Boczko 2014-05-08 13:21:06 UTC
Created attachment 276158 [details] [review]
ephy-window: Move the reload button to the header bar

If you want to test it (when I try it I see I need to move the mouse from
the entry to the end of the headerbar to stop/reload, it not so convenient).
Comment 5 Yosef Or Boczko 2014-05-08 13:23:54 UTC
At the same time, I want to link to bug #725166, because it really good to have
all the action buttons at the same side, so the user not need to move the pointer/mouse
from one side to other all the time.
Comment 6 Michael Catanzaro 2014-05-08 14:36:42 UTC
I also really want to see the reload button in the header bar.  It seems to me that the case where the entry is already visible (in which case, reload inside the entry is slightly more convenient) is not as important as the more common case where the entry is not visible (in which case, reload outside the entry is significantly more convenient and less confusing).
Comment 7 Carlos Garcia Campos 2014-05-08 15:41:32 UTC
(In reply to comment #1)
> I see here only two options - to move the reload/stop button to the header bar,
> or to leave it in the search/entry/address bar.
> 
> I think we have some discussions on this already, and we decided to leave the
> reload/stop
> button in the entry bar.

Yes, I don't remember how many times I've tried to convince you all of making the reload/stop button discoverable :-)
Comment 8 Carlos Garcia Campos 2014-05-08 15:44:14 UTC
(In reply to comment #3)
> I just want to noice the fact the reload button displayed when you open a new
> tab and start to loading page (before the page finish loading), so in the time
> the
> page still in loading, the user can to click on the stop button to stop the
> loading.

The switch happens when the load is committed, not finished, which is often fast enough to not see the reload button. Having the button in the toolbar is also consistent with web app mode.
Comment 9 Yosef Or Boczko 2014-05-08 15:48:58 UTC
Now when I try it out with the patch, I see why we really don't want to see the
reload button on one of the sides of the headerbar, instead in the title (at the middle
of the headerbar) - you need to move the cursor/pointer/mouse to the edge of the
headerbar, when the title/address bar is actualy in the middle of the headerbar, what
mean the user moved the cursor too much time from the middle to the edge and from
the edge to middle.

Now the user can to search/edit the url and also to stop/reload the page in the same
place, without too much move of the cursor.
Comment 10 Carlos Garcia Campos 2014-05-08 15:53:30 UTC
Why is that a problem? should we move also the navigation buttons, new tab, gear menu and close button to the center to avoid having to move the cursor too much? how is that better than having to find the button in the UI (or learn where it is) and then click first in the title and then in the button?
Comment 11 Carlos Alberto Lopez Perez 2014-05-08 15:57:34 UTC
(In reply to comment #9)
> Now when I try it out with the patch, I see why we really don't want to see the
> reload button on one of the sides of the headerbar, instead in the title (at
> the middle
> of the headerbar) - you need to move the cursor/pointer/mouse to the edge of
> the
> headerbar, when the title/address bar is actualy in the middle of the
> headerbar, what
> mean the user moved the cursor too much time from the middle to the edge and
> from
> the edge to middle.
> 
> Now the user can to search/edit the url and also to stop/reload the page in the
> same
> place, without too much move of the cursor.

I think that when the use edits the URL, he is not interested in clicking the Stop/Reload button.

When the user wants to click the reload button, the mouse pointer can be at any random part of the webpage. Speaking for myself, the typical case when I click the reload button is because the page has loaded, I'm reading it, but for some reason I want to refresh it to check for newer changes on the page.

So the distance between the URL text and the reload button I think is not relevant.
Comment 12 Carlos Garcia Campos 2014-05-09 10:57:51 UTC
Review of attachment 276158 [details] [review]:

This looks good to me, code is simpler and we don't need a special case for app mode. I wonder if we should move the button close to the other navigation buttons instead in both cases (normal and app mode)
Comment 13 Yosef Or Boczko 2014-05-09 12:01:35 UTC
(In reply to comment #12)
> Review of attachment 276158 [details] [review]:
> 
> This looks good to me, code is simpler and we don't need a special case for app
> mode. I wonder if we should move the button close to the other navigation
> buttons instead in both cases (normal and app mode)

Where exactly, between the new tab button and the navigation buttons or after the
new tab button ?
Comment 14 Yosef Or Boczko 2014-05-20 09:42:18 UTC
Created attachment 276835 [details] [review]
ephy-window: Move the reload button to the header bar

I try a „new” approach - put all the navigation buttons in the same
place, so with this patch I moved the reload button to the end of the
navigation/back/forward box.

It look really nice, for me.
Comment 15 Yosef Or Boczko 2014-05-20 09:43:02 UTC
Created attachment 276836 [details]
Screenshot - the reload button in the navigation box
Comment 16 Adrian Perez 2014-05-20 14:33:34 UTC
(In reply to comment #15)
> Created an attachment (id=276836) [details]
> Screenshot - the reload button in the navigation box

Just out of curiosity: is the screenshot using right-to-left widget
direction? I understand that in the left-to-right (default) direction,
the back-forward-stop/reload-newtab buttons would be in the left corner
of the header bar.

This solutions looks good to me, and there is one nice thing I have
noticed: having the stop/reload button next to the back-forward pair
is actually good because it is not uncommon to stop loading a page,
and *immediately* press the back button. So with your proposed
arrangement the pointer travels less for that use-case, which is
a good thing (IMHO).

Let's see what the others think, but yours looks like a good
solution to me.
Comment 17 Carlos Alberto Lopez Perez 2014-05-20 14:45:25 UTC
(In reply to comment #16)
> This solutions looks good to me, and there is one nice thing I have
> noticed: having the stop/reload button next to the back-forward pair
> is actually good because it is not uncommon to stop loading a page,
> and *immediately* press the back button. So with your proposed
> arrangement the pointer travels less for that use-case, which is
> a good thing (IMHO).
> 
> Let's see what the others think, but yours looks like a good
> solution to me.

This looks like the perfect place for the stop/reload button :)

I love it.
Comment 18 Yosef Or Boczko 2014-05-20 14:46:43 UTC
(In reply to comment #16)
> (In reply to comment #15)
> > Created an attachment (id=276836) [details] [details]
> > Screenshot - the reload button in the navigation box
> 
> Just out of curiosity: is the screenshot using right-to-left widget
> direction? I understand that in the left-to-right (default) direction,
> the back-forward-stop/reload-newtab buttons would be in the left corner
> of the header bar.
> 
> This solutions looks good to me, and there is one nice thing I have
> noticed: having the stop/reload button next to the back-forward pair
> is actually good because it is not uncommon to stop loading a page,
> and *immediately* press the back button. So with your proposed
> arrangement the pointer travels less for that use-case, which is
> a good thing (IMHO).
> 
> Let's see what the others think, but yours looks like a good
> solution to me.

Yes, it in RTL, what mean in LTR the back/forward/reload new buttons needs to be
in the left side.

(In reply to comment #17)
> (In reply to comment #16)
> > This solutions looks good to me, and there is one nice thing I have
> > noticed: having the stop/reload button next to the back-forward pair
> > is actually good because it is not uncommon to stop loading a page,
> > and *immediately* press the back button. So with your proposed
> > arrangement the pointer travels less for that use-case, which is
> > a good thing (IMHO).
> > 
> > Let's see what the others think, but yours looks like a good
> > solution to me.
> 
> This looks like the perfect place for the stop/reload button :)
> 
> I love it.

Me too :-)
Comment 19 Michael Catanzaro 2014-05-20 18:42:03 UTC
Review of attachment 276835 [details] [review]:

This patch seems to work well, but I think the stop/reload button should be separate (like New Tab) rather than linked to Back/Forward.
Comment 20 Michael Catanzaro 2014-05-20 18:43:29 UTC
This incidentally fixes Bug #689536
Comment 21 Yosef Or Boczko 2014-05-20 18:45:16 UTC
(In reply to comment #20)
> This incidentally fixes Bug #689536

If you run epiphany with gtk+ from git master + gnome-theme-stansard from
git master, it already fixes (and broken on RTL!)
Comment 22 Carlos Garcia Campos 2014-05-21 07:08:35 UTC
I don't mind where the button is as long as it's not hidden in the location bar.
Comment 23 Michael Catanzaro 2014-06-02 02:23:37 UTC
*** Bug 725191 has been marked as a duplicate of this bug. ***
Comment 24 Yosef Or Boczko 2014-06-11 17:52:39 UTC
Created attachment 278284 [details] [review]
ephy-window: Move the reload button to the header bar
Comment 25 Yosef Or Boczko 2014-07-07 13:02:38 UTC
I think it look better when the reload button in the navigation box and not separeat
from them.

Also, it reasonable logic to put all the action-on-the-page at the same place. i.e. the
back/forward and the reload button do the same action on the current page.

So, someone can to review my trivial patch?
Comment 26 Michael Catanzaro 2014-07-07 15:25:03 UTC
(In reply to comment #25)
> I think it look better when the reload button in the navigation box and not
> separeat
> from them.

Back and Forward should be linked because they're logical opposites: this is also why we link undo and redo.  Even though reload affects the current page, I don't think it's sufficiently related to back/forward to be linked with them. (I think you do have it in the best position, though, between back/forward and new tab.)
Comment 27 Yosef Or Boczko 2014-07-07 17:37:10 UTC
Created attachment 280077 [details]
Screenshot - the reload button linked to the navigation buttons
Comment 28 Yosef Or Boczko 2014-07-07 17:37:40 UTC
Created attachment 280078 [details]
Screenshot - the reload button not linked to the navigation buttons
Comment 29 Yosef Or Boczko 2014-07-07 18:10:37 UTC
Created attachment 280083 [details]
Screenshot - the reload button between the back and the forward buttons
Comment 30 Carlos Garcia Campos 2014-08-07 15:50:06 UTC
Review of attachment 278284 [details] [review]:

I've had a patch applied locally to move the reload button to the header bar, and I really thinks it's much better than having it hidden in the location bar. But I agree it shouldn't be linked to the navigation buttons. We could probably leave it on the left for consistency with the web app mode.
Comment 31 Carlos Garcia Campos 2014-08-07 15:52:35 UTC
(In reply to comment #30)
> Review of attachment 278284 [details] [review]:
> 
> I've had a patch applied locally to move the reload button to the header bar,
> and I really thinks it's much better than having it hidden in the location bar.
> But I agree it shouldn't be linked to the navigation buttons. We could probably
> leave it on the left for consistency with the web app mode.

I meant right, not left (for RTL locales of course, and the opposite for LTR)
Comment 32 Michael Catanzaro 2014-08-07 16:09:32 UTC
I'd probably favor moving it to the left (in LTR) in web app mode as well, but I don't really care either way as long as it's on the same side of the header bar in both normal mode as in web app mode.
Comment 33 Yosef Or Boczko 2014-08-07 17:53:13 UTC
Start - left in LTR and right in RTL, End - right in LTR and left in RTL.

I prefer to move the reload button to the start of the headerbar, between the navigation
buttons and the new tab button.
In other words, I wants all the action buttons in the same side of the headerbar, so I not
needs to move the cursor from the start of the headerbar to the end of it and vise versa
all the time.

For the linked idea, ok, not linked.

(btw, Carlos, I see the reload button in the end of the headerbar in your screenshot in
one of your blog posts.)
Comment 34 Yosef Or Boczko 2014-08-10 07:38:49 UTC
Created attachment 283027 [details] [review]
ephy-window: Move the reload button to the header bar

From the location entry.
Comment 35 Carlos Garcia Campos 2014-08-10 07:49:39 UTC
Review of attachment 283027 [details] [review]:

Thanks!
Comment 36 Yosef Or Boczko 2014-08-10 08:49:16 UTC
Review of attachment 283027 [details] [review]:

Pushed as a9cac88 - ephy-window: Move the reload button to the header bar