GNOME Bugzilla – Bug 727221
e-util: Port to thread-safe ECategories API
Last modified: 2014-03-28 10:46:36 UTC
This is a follow-up from bug #727137, porting Evolution to use the new thread-safe ECategories API. This patch hasn't been thoroughly tested.
Created attachment 273153 [details] [review] e-util: Port to thread-safe ECategories API This ports the following two function calls throughout Evolution: • e_categories_get_list() to e_categories_dup_list() • e_categories_get_icon_file_for() to e_categories_dup_icon_file_for() It necessarily changes some internal e-util API: • e_util_get_searchable_categories() to e_util_dup_searchable_categories() This bumps the EDS requirement to 3.13.1.
Review of attachment 273153 [details] [review]: Thanks. Please fix "the one" thing below and commit to master. ::: calendar/gui/e-cal-component-preview.c @@ +231,3 @@ for (iter = list; iter != NULL; iter = iter->next) { const gchar *category = iter->data; + gchar *icon_file; /* owned */ Please do not write the /* owner */ comment, it's understood from the fact that the string variable is defined as non-const. Remove the comment from the whole set of changes.
Pushed to master with the changes requested above. Thanks for the fast review! Attachment 273153 [details] pushed as 61b4bac - e-util: Port to thread-safe ECategories API