After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726232 - wall-clock: Always use the ratio character for time strings
wall-clock: Always use the ratio character for time strings
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 696497 699325 730402 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-03-13 11:35 UTC by Kalev Lember
Modified: 2014-05-31 06:47 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
wall-clock: Always use the ratio character for time strings (3.16 KB, patch)
2014-03-13 11:36 UTC, Kalev Lember
committed Details | Review

Description Kalev Lember 2014-03-13 11:35:55 UTC
In gnome-desktop code we have time format strings with colons, and expect translators to replace them with the ratio character whenever it makes sense. It even goes as far as we have a mostly empty en.po file that only replaces colon with ratio.

This doesn't really scale since translators often overlook the format strings.

The patch here implements Bastien Nocera's idea to make the situation saner, so that translators could keep using plain colon in the .po files:

11:14 < hadess> csoriano__, why can't you change the ratio character after translation?
11:15 < hadess> csoriano__, you could even fix the whole problem by doing that, and making sure that the direction unicode mark is inserted to make sure things don't get reordered
Comment 1 Kalev Lember 2014-03-13 11:36:26 UTC
Created attachment 271703 [details] [review]
wall-clock: Always use the ratio character for time strings

Since the ratio character looks visually more pleasing in time strings,
replace colons with the ratio characters whenever possible.
Comment 2 Yosef Or Boczko 2014-05-20 18:30:14 UTC
*** Bug 730402 has been marked as a duplicate of this bug. ***
Comment 3 Yosef Or Boczko 2014-05-20 18:34:37 UTC
I think it will be great to make more release (3.12.3) with this patch.
IIRC, this is an old bug I hear from the some Hebrew users.
Comment 4 Yosef Or Boczko 2014-05-21 12:55:51 UTC
<yoseforb> hadess: Hey, you can to llok to review the patch in bug 726232?
<hadess> yoseforb, no, not until we have a working test suite
Comment 5 Bastien Nocera 2014-05-30 12:19:23 UTC
Attachment 271703 [details] pushed as 665125e - wall-clock: Always use the ratio character for time strings
Comment 6 Yosef Or Boczko 2014-05-30 12:20:29 UTC
Please, push the patch to the gnome-3-12 branch too.
Comment 7 Bastien Nocera 2014-05-30 12:33:36 UTC
*** Bug 696497 has been marked as a duplicate of this bug. ***
Comment 8 Bastien Nocera 2014-05-30 12:51:09 UTC
*** Bug 699325 has been marked as a duplicate of this bug. ***
Comment 9 Evgeny Bobkin 2014-05-31 06:47:08 UTC
Hmm, actually, I asked Matthias Clasen about this idea half a year ago, and his reply was that this is insane ;)