GNOME Bugzilla – Bug 725515
test-printf fails on W32
Last modified: 2014-08-02 12:31:58 UTC
It expects the child to output text with '\n' EOLs, but the child stdout defaults to text mode, and the output contains '\r\n' EOLs.
Created attachment 270716 [details] [review] Fix printf-tests on W32 by enabling binary mode in the test
Created attachment 274827 [details] [review] Fix printf-tests on W32 by enabling binary mode in the test v2: same thing, just attached with git bz
Review of attachment 274827 [details] [review]: A comment why this is needed would be good.
Created attachment 281864 [details] [review] Fix printf-tests on W32 by enabling binary mode in the test v2: added a comment that explains why binary mode is enabled
Review of attachment 281864 [details] [review]: Looks good to me. Let's get an ack from somebody.
Review of attachment 281864 [details] [review]: Is the failing tests just the ones that use g_test_trap_assert_stdout ? If yes, then it is just in two places, and one of them is already ifdeffed... if that's the case I think I would prefer to explicitly assert that the output matches \r\n on windows, instead of relaying on the binary flag
Created attachment 282328 [details] [review] Fix printf-tests on W32 by ifdefing the expected output test-printf passes with this patch as well.
Review of attachment 282328 [details] [review]: looks good
Attachment 282328 [details] pushed as 40650e3 - Fix printf-tests on W32 by ifdefing the expected output