After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724049 - Impossible to automatically place windows directly under the top-panel
Impossible to automatically place windows directly under the top-panel
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 726869 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-02-10 16:24 UTC by Hans de Goede
Modified: 2014-03-22 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix positioning error for manually positioned windows (1.43 KB, patch)
2014-03-05 22:07 UTC, Owen Taylor
committed Details | Review

Description Hans de Goede 2014-02-10 16:24:38 UTC
I start 4 xterms from a script at login like this:

xterm -geometry +278+19&
xterm -geometry +278+512&
xterm -geometry +1100+19&
xterm -geometry +1100+512&

This used to work fine, but whatever value I try for the +19 now it does not work, it seems as if the top of the windows decoration (top of the titlebar) always is placed exactly one title-bar height below the bottom of the panel instead of directly against the panel.

Starting at +29 or some such it does become placed lower then before, but any value less then +29 is treated the same.
Comment 1 Owen Taylor 2014-03-05 22:07:20 UTC
Created attachment 271044 [details] [review]
Fix positioning error for manually positioned windows

The "original coordinates" passed into meta_window_place() were the
coordinates of the client rectangle not the frame rectangle. When
meta_window_place() didn't place because the window was manually
positioned (e.g., 'xterm -geometry +x+y') that resulted in a window
being offset by the frame dimensions.
Comment 2 Owen Taylor 2014-03-05 22:08:42 UTC
This regressed with:

commit 4ee9f3563bb8315af71bebe31d06bd08b121d827
Author: Owen W. Taylor <otaylor@fishsoup.net>
Date:   Fri Nov 15 16:11:20 2013 -0500

    Use utility functions to convert between frame and client rectangles

[...]

    Switch the placement code to place the frame rectangle rather
    than the client window - this simplifies things considerably.
Comment 3 drago01 2014-03-05 22:13:05 UTC
Review of attachment 271044 [details] [review]:

Looks good and works in testing.
Comment 4 Owen Taylor 2014-03-05 22:22:07 UTC
Attachment 271044 [details] pushed as 4c2e39b - Fix positioning error for manually positioned windows
Comment 5 Florian Müllner 2014-03-22 11:15:06 UTC
*** Bug 726869 has been marked as a duplicate of this bug. ***