GNOME Bugzilla – Bug 722495
Support building printers panel without smbclient
Last modified: 2014-01-20 11:45:23 UTC
Created attachment 266611 [details] [review] Proposed patch Fix for bug 693923 completely disables the printers panel when smbclient is not available. The attached patch changes that to build the printers panel without Samba support. I haven't been able to fully test it with smbclient enabled, however, the patch is simple enough.
No, I don't think that's something we want. If the printers panel is enabled, it should be fully featured. If you compile without libsmbclient, documentation is invalidated, and send people trying to add SMB printers on a wild goose chase as to why their printers aren't recognised. If disk space is at a premium, I'd rework the packages to include the minimal dependencies for libsmbclient instead of removing smbclient support and breaking the printers panel in unexpected ways.
I can see a point in the documentation issue. However, the current situation is that the whole printers panel gets disabled if smbclient (or CUPS) is not available. The documentation mismatch is much worse if the user can't even open the printers panel as the GNOME help for 'Hardware' still includes 'Printing'. In other words, I don't see a situation where this patch makes things worse for users.
(In reply to comment #2) > I can see a point in the documentation issue. However, the current situation is > that the whole printers panel gets disabled if smbclient (or CUPS) is not > available. The documentation mismatch is much worse if the user can't even open > the printers panel as the GNOME help for 'Hardware' still includes 'Printing'. At least the message is clear. There's no printing panel, so no printing support. The Printers documentation can be removed all together if the distributor doesn't want to ship the Printers panel. > In other words, I don't see a situation where this patch makes things worse for > users. I fail to see how it makes it better for users.