GNOME Bugzilla – Bug 722411
Functions from gvfsdbusutils.c not found when using HAL backend
Last modified: 2015-04-01 17:27:34 UTC
Created attachment 266544 [details] [review] Simple patch to fix the error monitor/gphoto2/hal-pool.c daemon/gvfsbackendcdda.c daemon/gvfsbackendgphoto2.c These three files use the function _g_dbus_connection_integrate_with_main, which is defined in monitor/hal/gvfsdbusutils.c, but they connot find this function. I move monitor/hal/gvfsdbusutils.c to common/gvfsdbusutils.c and modify some Makefile.am to solve this problem. Is it a correct way to resolve this issue?
In general this looks ok, but i'm a bit uncertain about the use of USE_HAL in common/Makefile.am. Not sure, but it seems this may be set if hal was detected, but gudev also was detected. I'd like to make sure we link in the dbus libs only if hal is actually *used*.
Actually i think we should put the libdbus helpers in a separate library and only link to that from the backends that require it. We don't want the other backends to pick up a libdbus backend.
Comment on attachment 266544 [details] [review] Simple patch to fix the error Marking as reviewed, because alex reviewed it already in previous comments...
Created attachment 296216 [details] [review] Updated patch
Review of attachment 296216 [details] [review]: Looks fine (untested). Just one thing, can you rename the libgvfscommon-dbus to libgvfscommon-hal, and gvfsdbusutils.* to gvfshalutils.* This is so that it is clear that these are only for hal stuff and not general dbus stuff.
Created attachment 300770 [details] [review] Updated patch with gvfsdbusutils.[ch] renamed to gvfshalutils.[ch]
Review of attachment 300770 [details] [review]: Thanks
Attachment 300770 [details] pushed as 32377d1 - Fix build error when using HAL backend