GNOME Bugzilla – Bug 722336
tls/connection/close-during-handshake has become unreliable
Last modified: 2014-01-20 17:17:48 UTC
In Ubuntu, we run glib-networking's installed-tests automatically as part of regression testing. Lately the test /tls/connection/close-during-handshake started failing intermittently: /tls/connection/close-during-handshake: ** GLib-Net:ERROR:connection.c:131:teardown_connection: assertion failed: (!(test->client_connection)) Test glib-networking/connection.test failed: Child process killed by signal 6 https://jenkins.qa.ubuntu.com/view/Trusty/view/AutoPkgTest/job/trusty-adt-glib-networking/29/ARCH=i386,label=adt/console After looking at the upload timings of glib, this seems to have begun with the upload of glib 2.39.2. bug #721921 is for some glib test flakiness that happened around the same time. Ryan blamed that one on the test itself.
what version of glib-networking exactly?
Oops, I'm sorry - I forgot to say. It's 2.39.3.
Created attachment 266631 [details] [review] tls/tests: try to fix a flaky test ---- could you try applying this patch to your package to see if it makes the failures go away?
Cheers, I've upload it to Ubuntu. If you like, keep an eye on https://jenkins.qa.ubuntu.com/view/Trusty/view/AutoPkgTest/job/trusty-adt-glib-networking/ which should get new test results shortly. If the first result passes, I'll then retry it a few times to see if it's solid. (Even if not, this patch looks sensible to me)
Oops, it happens for write-during-handshake (as well?). I've applied the same fix there; testing that now.
Review of attachment 266631 [details] [review]: I've run it three times with the fix to write_during_handshake too and it's been fine every time. Thanks.
pushed with the fix for write_during_handshake as well. thanks
*** Bug 719727 has been marked as a duplicate of this bug. ***