GNOME Bugzilla – Bug 720731
Show file renames in diff stats
Last modified: 2014-06-28 07:03:21 UTC
With patch https://bugzilla.gnome.org/show_bug.cgi?id=720127 to libgit2-glib, we can show renames now.
Created attachment 264526 [details] [review] Show file renames in diff stats
Created attachment 264527 [details] Screenshot of the diff rename We can see the changes between the renamed files too.
Review of attachment 264526 [details] [review]: ::: libgitg/resources/diff-view-html-builder.js @@ +114,3 @@ + if (file.similarity > 0) + { + filepath = file.file.new.path + '(Previously: ' +file.file.old.path + ')'; Instead of "Previously" I think it might be better to do something like: old path → new path
(In reply to comment #3) > Review of attachment 264526 [details] [review]: > > ::: libgitg/resources/diff-view-html-builder.js > @@ +114,3 @@ > + if (file.similarity > 0) > + { > + filepath = file.file.new.path + '(Previously: ' +file.file.old.path + > ')'; > > Instead of "Previously" I think it might be better to do something like: > > old path → new path Actually, It was my first choice, but I thought it would be better to show the new file first, it is more clear that which file the diff below belongs to.
See branch wip/techlivezh/show-diff-renames
Then what about new path ← old path
(In reply to comment #6) > Then what about > > new path ← old path Yeah, that'd be fine.
Created attachment 264861 [details] [review] Show file renames in diff stats
Created attachment 264862 [details] [review] Show file renames in diff stats
Thanks! I've committed a slightly updated patch.