GNOME Bugzilla – Bug 720470
Introspection revamp and build fix for FreeBSD
Last modified: 2014-01-23 12:12:35 UTC
Created attachment 264202 [details] [review] Introspection reworked Introspection support doesn't work on FreeBSD. Ryan Lortie said that there is a general way of doing introspection instead of doing it by hand. I used the following documentation to impliment this. While it works for me, I not quite sure if it all done correctly. https://wiki.gnome.org/Projects/GObjectIntrospection/AutotoolsIntegration
Created attachment 264203 [details] [review] include stddef.h for size_t on FreeBSD
Review of attachment 264202 [details] [review]: It's unusual to put the .m4 of introspection under source control. Usually it's better to just have gobject-introspection as a hard build dependency when building from git (which will result in the m4 being found in the system's aclocal and automatically copied in and included in the tarball). The --enable-introspection in the Makefile also seems suspicious. This should probably be on by default...
Review of attachment 264202 [details] [review]: Sorry. Wrong status :)
Comment on attachment 264202 [details] [review] Introspection reworked Sorry. Wrong status :)
Review of attachment 264203 [details] [review]: This is harmless. Please commit it now. Any word on getting an updated patch for the other one?
Created attachment 265002 [details] [review] Update patch.
Created attachment 266609 [details] [review] Introspection patch update. This patch has two additional fixes. 1) Gtkvnc-gir needs Gvnc-gir to be build first. So register the dependency. 2) Attempt to fix the gir build with jobs enabled.
Fixed in 3 commits. commit ff7b8c29d2efd8e0262d76457ed8302397c84148 Author: Daniel P. Berrange <berrange@redhat.com> Date: Thu Jan 23 12:11:08 2014 +0000 Fix parallel build of introspection gir files commit 6359563b7b83e958be53dd6efbbac899802edfc3 Author: Koop Mast <kwm@rainbow-runner.nl> Date: Sat Dec 14 23:36:24 2013 +0100 Rework introspection support so it works on FreeBSD. commit 16b5ed3e4237668a8f352c0a1408e2460c5c1e89 Author: Koop Mast <kwm@rainbow-runner.nl> Date: Sat Dec 14 23:27:11 2013 +0100 Add stddef.h for size_t on FreeBSD.