---- Reported by geary-maint@gnome.bugs 2013-08-27 05:34:00 -0700 ----

Original Redmine bug id: 7399
Original URL: http://redmine.yorba.org/issues/7399
Searchable id: yorba-bug-7399
Original author: Yosef Or Boczko
Original description:

This make the window to be consistent with the new design of GNOME 3 (GNOME
3.10).

See: https://wiki.gnome.org/Design/HIG/HeaderBars

See also the last post in the blog of Matthias:
http://blogs.gnome.org/mclasen/2013/08/23/gnome-3-10-sightings/

See also the image.



---- Additional Comments From geary-maint@gnome.bugs 2013-10-14 15:40:00 -0700 ----

### History

####

#1

Updated by Yosef Or Boczko 3 months ago

btw, now I see the date of the message (sent a few minutes ago) is "(null)".
the bug...

####

#2

Updated by Charles Lindsay 3 months ago

  * **Status** changed from _Open_ to _Review_

####

#3

Updated by Jim Nelson 3 months ago

  * **Category** set to _ux_
  * **Target version** set to _0.5.0_

Unfortunately, Geary has a minimum requirement of GTK 3.6 for the 0.4 release.
Since this uses a 3.10 symbol, we can't take it for this release.

It's possible we could work this into 0.5, so we'll take a look at this then.

####

#4

Updated by Yosef Or Boczko 3 months ago

Maybe to add #ifdef for this?

Just if have GTK+ 3.10 - make the top bar (toolbar) as titlebar and add close
button.

?

####

#5

Updated by Jim Nelson 3 months ago

We've gone down the #ifdef route before with less than satisfying results.
It's too easy for things to break over time, and leads to bit-rot.

####

#6

Updated by Yosef Or Boczko 3 months ago

OK.

Thanks.

####

#7

Updated by Alexander Wilms about 1 month ago

Why didn't you use an actual Gtk.HeaderBar in the patch?
http://valadoc.org/#!api=gtk+-3.0/Gtk.HeaderBar

This way you wouldn't need to add the close button and the sperator manually.

####

#8

Updated by Yosef Or Boczko about 1 month ago

OK, I can to port to GtkHeaderBar, it realy better,

but now I can't, because I can't build Geary - I have

WebKitGTK+ 2.2.0 (see 7023).

####

#9

Updated by Yosef Or Boczko about 1 month ago

  * **File** 0001-Make-the-top-bar-as-titlebar-and-add-close-button.patch added
  * **File** geary-start-dev-0.5-headerbar.png added

I attached a patch which port PillToolbar to Gtk.HeaderBar.

I need also to set a title to the headerbar, but it need design.

It can to be good idea if the title of the headerbar is will the

name of the current folder, and the subtitle of the headerbar

will the title of the current message.

####

#10

Updated by Yosef Or Boczko about 1 month ago

  * **File** 0002-Set-the-title-of-the-headerbar-as-the-current-folder.patch added

####

#11

Updated by Yosef Or Boczko about 1 month ago

  * **File** 0003-WIP-title-headerbar.patch added
  * **File** geary-headerbar-wip-title.png added

This patch is after the two patches above.

This patch make the title of the header as

the nickname of the current account, and

the subtitle as the name of the current

folder with number of unread mails.



--- Bug imported by chaz@yorba.org 2013-11-21 20:21 UTC  ---

This bug was previously known as _bug_ 7399 at http://redmine.yorba.org/show_bug.cgi?id=7399
Imported an attachment (id=260710)
Imported an attachment (id=260711)
Imported an attachment (id=260712)
Imported an attachment (id=260713)
Imported an attachment (id=260714)
Imported an attachment (id=260715)
Imported an attachment (id=260716)

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution