After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711799 - Implement GCleanup in libgio
Implement GCleanup in libgio
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on: 711798 711801 711802 711803 711804 711805 711806 711807 711808
Blocks: 627423
 
 
Reported: 2013-11-10 20:57 UTC by Stef Walter
Modified: 2018-05-24 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gio: Define cleanup scope and list for libgio (1.98 KB, patch)
2013-11-10 21:00 UTC, Stef Walter
none Details | Review
gdbus: Cleanup global static data (1.97 KB, patch)
2013-11-10 21:00 UTC, Stef Walter
none Details | Review
gioenumtypes: Push enum GTypes onto cleanup list (809 bytes, patch)
2013-11-10 21:00 UTC, Stef Walter
none Details | Review
giomodule: Cleanup global data (2.24 KB, patch)
2013-11-10 21:00 UTC, Stef Walter
none Details | Review
glocalfile: Cleanup global data (651 bytes, patch)
2013-11-10 21:04 UTC, Stef Walter
none Details | Review
gresolver: Cleanup global data (807 bytes, patch)
2013-11-10 21:04 UTC, Stef Walter
none Details | Review
gsocketconnection: Cleanup global data (1.25 KB, patch)
2013-11-10 21:04 UTC, Stef Walter
none Details | Review
gtask: Cleanup thread pool (942 bytes, patch)
2013-11-10 21:04 UTC, Stef Walter
none Details | Review
gcancellable: Free up GPrivate in right cleanup context (797 bytes, patch)
2013-11-10 21:04 UTC, Stef Walter
none Details | Review
gfileinfo: Cleanup memory (1.49 KB, patch)
2013-11-10 21:04 UTC, Stef Walter
none Details | Review
gio/tests: Prevent random gio modules from screwing up these tests (3.82 KB, patch)
2013-11-10 21:04 UTC, Stef Walter
none Details | Review
filter-streams: Cleanup custom classes in test (792 bytes, patch)
2013-11-10 21:08 UTC, Stef Walter
none Details | Review
gio: Define cleanup scope and lists for gio tests (10.04 KB, patch)
2013-11-10 21:08 UTC, Stef Walter
none Details | Review
gsubprocess: Cleanup GSubprocess correctly (4.35 KB, patch)
2013-11-10 21:11 UTC, Stef Walter
none Details | Review
gdbusintrospection: Free up cache when done with it (932 bytes, patch)
2013-11-10 21:15 UTC, Stef Walter
none Details | Review
gdbusname: Cleanup global tables (1.38 KB, patch)
2013-11-10 21:15 UTC, Stef Walter
none Details | Review
gtestdbus: Cleanup io channel which would otherwise leak (720 bytes, patch)
2013-11-10 21:21 UTC, Stef Walter
none Details | Review
gdbus-example-export: Fix behavior when using cleanup (1.17 KB, patch)
2013-11-10 21:23 UTC, Stef Walter
none Details | Review
gdbus-testserver: Fix behavior during cleanup (1.58 KB, patch)
2013-11-10 21:24 UTC, Stef Walter
none Details | Review
mimeapps: Don't make this test dependent on behavior of gvfs (738 bytes, patch)
2013-11-10 21:26 UTC, Stef Walter
none Details | Review
gdesktopappinfo: Free memory caches and desktop file monitors during cleanup (2.71 KB, patch)
2013-11-10 21:26 UTC, Stef Walter
none Details | Review

Description Stef Walter 2013-11-10 20:57:28 UTC
Implement cleanup in libgio and associated tests.

I've split this out from bug #627423 for simplicity, since there are quite a
few patches. That should make it easier to review, track dependencies and so
on.

Goal here is to have all gobject related tests running without leaks or memory
issues.
Comment 1 Stef Walter 2013-11-10 21:00:17 UTC
Created attachment 259467 [details] [review]
gio: Define cleanup scope and list for libgio
Comment 2 Stef Walter 2013-11-10 21:00:22 UTC
Created attachment 259468 [details] [review]
gdbus: Cleanup global static data
Comment 3 Stef Walter 2013-11-10 21:00:26 UTC
Created attachment 259469 [details] [review]
gioenumtypes: Push enum GTypes onto cleanup list
Comment 4 Stef Walter 2013-11-10 21:00:57 UTC
Created attachment 259470 [details] [review]
giomodule: Cleanup global data
Comment 5 Stef Walter 2013-11-10 21:04:07 UTC
Created attachment 259472 [details] [review]
glocalfile: Cleanup global data
Comment 6 Stef Walter 2013-11-10 21:04:12 UTC
Created attachment 259473 [details] [review]
gresolver: Cleanup global data
Comment 7 Stef Walter 2013-11-10 21:04:16 UTC
Created attachment 259474 [details] [review]
gsocketconnection: Cleanup global data
Comment 8 Stef Walter 2013-11-10 21:04:22 UTC
Created attachment 259475 [details] [review]
gtask: Cleanup thread pool
Comment 9 Stef Walter 2013-11-10 21:04:27 UTC
Created attachment 259476 [details] [review]
gcancellable: Free up GPrivate in right cleanup context
Comment 10 Stef Walter 2013-11-10 21:04:32 UTC
Created attachment 259477 [details] [review]
gfileinfo: Cleanup memory
Comment 11 Stef Walter 2013-11-10 21:04:52 UTC
Created attachment 259478 [details] [review]
gio/tests: Prevent random gio modules from screwing up these tests
Comment 12 Stef Walter 2013-11-10 21:08:20 UTC
Created attachment 259482 [details] [review]
filter-streams: Cleanup custom classes in test
Comment 13 Stef Walter 2013-11-10 21:08:26 UTC
Created attachment 259483 [details] [review]
gio: Define cleanup scope and lists for gio tests
Comment 14 Stef Walter 2013-11-10 21:11:25 UTC
Created attachment 259488 [details] [review]
gsubprocess: Cleanup GSubprocess correctly

Although it's nice that GSubprocess object lives until its
child goes away, this can't be the case during cleanup and or
unloading of gio, since the GLib worker thread will run non-existant
code.

So in the case that GIO hits cleanup, we finalize the GSubprocess
regardless of the state of its child.
Comment 15 Stef Walter 2013-11-10 21:15:04 UTC
Created attachment 259491 [details] [review]
gdbusintrospection: Free up cache when done with it
Comment 16 Stef Walter 2013-11-10 21:15:08 UTC
Created attachment 259492 [details] [review]
gdbusname: Cleanup global tables
Comment 17 Stef Walter 2013-11-10 21:21:02 UTC
Created attachment 259496 [details] [review]
gtestdbus: Cleanup io channel which would otherwise leak
Comment 18 Stef Walter 2013-11-10 21:23:03 UTC
Created attachment 259501 [details] [review]
gdbus-example-export: Fix behavior when using cleanup
Comment 19 Stef Walter 2013-11-10 21:24:58 UTC
Created attachment 259505 [details] [review]
gdbus-testserver: Fix behavior during cleanup
Comment 20 Stef Walter 2013-11-10 21:26:42 UTC
Created attachment 259507 [details] [review]
mimeapps: Don't make this test dependent on behavior of gvfs
Comment 21 Stef Walter 2013-11-10 21:26:48 UTC
Created attachment 259508 [details] [review]
gdesktopappinfo: Free memory caches and desktop file monitors during cleanup
Comment 22 GNOME Infrastructure Team 2018-05-24 15:57:39 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/785.