After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708921 - pbutils: Add codec-utility functions to support h265
pbutils: Add codec-utility functions to support h265
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 709093
 
 
Reported: 2013-09-27 12:48 UTC by sreerenj
Modified: 2013-10-02 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add codec-utility functions to support h265 (9.77 KB, patch)
2013-09-27 12:48 UTC, sreerenj 		needs-work Details | Review
Add codec-utility functions to support h265 (11.44 KB, patch)
2013-10-02 09:16 UTC, sreerenj 		needs-work Details | Review
Add codec-utility functions to support h265 (11.66 KB, patch)
2013-10-02 09:29 UTC, sreerenj 		committed Details | Review

Description sreerenj 2013-09-27 12:48:14 UTC 
Created attachment 255925 [details] [review]
Add codec-utility functions to support h265

Adding utility functions to pbutils to get/set the profile, tier and level for H265.
Comment 1 Sebastian Dröge (slomo) 2013-10-01 21:25:24 UTC 
Review of attachment 255925 [details] [review]:

Please also add this to the documentation, and win32/common/*.def.

::: gst-libs/gst/pbutils/codec-utils.c
@@ +4,3 @@
  *               2010 Collabora Multimedia
  *               2010 Nokia Corporation
+ *		 2013 Intel Corporation

Please indent this properly, tabs and spaces mixed it seems

@@ +725,3 @@
+    tier = "High";
+  else
+    tier = "Main";

This should maybe be lower-case for consistency too

::: gst-libs/gst/pbutils/codec-utils.h
@@ +64,3 @@
+gboolean      gst_codec_utils_h265_caps_set_level_tier_and_profile (GstCaps      * caps,
+                                                                    const guint8 * profile_tier_level,
+                                                                    guint          len);

Please indent all functions in the h265 section properly... let the opening ( be in the same column for all of them, and one parameter per line for the first three functions too.
Comment 2 Sebastian Dröge (slomo) 2013-10-01 21:31:04 UTC 
Oh, and add "Since: 1.3" markers to the docs :)
Comment 3 Sebastian Dröge (slomo) 2013-10-01 21:32:43 UTC 
I mean 1.4 of course
Comment 4 sreerenj 2013-10-02 09:16:13 UTC 
Created attachment 256242 [details] [review]
Add codec-utility functions to support h265
Comment 5 Sebastian Dröge (slomo) 2013-10-02 09:19:48 UTC 
Review of attachment 256242 [details] [review]:

::: gst-libs/gst/pbutils/codec-utils.h
@@ +67,3 @@
+gboolean      gst_codec_utils_h265_caps_set_level_tier_and_profile (GstCaps      * caps,
+                                                                    const guint8 * profile_tier_level,
+                                                                    guint          len);

The alignment here is completely broken, probably mix of tabs and spaces
Comment 6 sreerenj 2013-10-02 09:29:25 UTC 
Created attachment 256243 [details] [review]
Add codec-utility functions to support h265

Aha, sorry. I hope it is okay now.
Comment 7 Sebastian Dröge (slomo) 2013-10-02 09:38:34 UTC 
commit 9ffaaddcbe71a38c37a14175942729664f4bf005
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed Oct 2 12:26:59 2013 +0300

    pbutils: Add codec-utility funtions to support H265
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708921