After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708674 - buttons/menus-have-icons option missing
buttons/menus-have-icons option missing
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-09-24 11:38 UTC by Milan Crha
Modified: 2014-02-03 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Milan Crha 2013-09-24 11:38:31 UTC
I guess this might go rather to gtk+, but anyway, the org.gnome.desktop.interface schema used to have buttons-have-icons and menus-have-icons in 3.8 time (and before), which is gone in 3.10.0. How does one enable these two options in 3.10.0+, to not have that lame look and feel without them, not talking about waste of artist's work and missing much easier orientation on buttons/menus when looking onto pictures, rather than read each single text on the screen? All that looks line in 80' of *the last century* - my screen can do more than 800x600, same as it has capability of 24bit colors (black and white pictogram instead of full color icons? It hurts...)
Comment 1 Bastien Nocera 2013-09-24 12:39:36 UTC
It's not in gsettings-desktop-schemas because gnome-settings-daemon doesn't use the setting anymore, as GTK+ doesn't respect the XSettings for it anymore either.
Comment 2 Milan Crha 2013-09-24 13:11:27 UTC
Yeah, true. I managed to find the commit in gtk which removed those items, with no explanation why. Only that each application can force it on per-item bases, which will not be the right look-and-feel for gtk applications, as it used to be.

William Jon McCann, could you explain the idea behind dropping desktop-wide option for this, please?
Comment 3 Jakub Steiner 2013-09-24 15:27:13 UTC
Being prepared to have your "darlings murdered" is a pre-requisite of any design work. Being that artist whose work is being "wasted" I can just note that part has absolutely no weight in the argument. Using something that's available has nothing to do with good design.
Comment 4 Matthew Barnes 2013-09-24 16:39:58 UTC
I have no objection to the changes in gsettings-desktop-schemas and gnome-settings-daemon, since those are GNOME-specific.

But gtk3 not respecting the XSettings is going too far.  This will break gtk3 apps in other desktop environments that use their own XSettings manager.

I'm still using an older gtk3 release, and I can open xfce4-appearance-settings and toggle the "Show images on buttons" and "Show images in menus" settings and my gtk3 apps respond by way of xfsettingsd instead of gnome-settings-daemon.
Comment 5 William Jon McCann 2013-09-24 16:50:29 UTC
In what way is Evolution broken in other desktop environments?
Comment 6 Milan Crha 2013-09-25 07:04:44 UTC
(In reply to comment #3)
> Being prepared to have your "darlings murdered" is a pre-requisite of any
> design work. Being that artist whose work is being "wasted" I can just note
> that part has absolutely no weight in the argument. Using something that's
> available has nothing to do with good design.

I'm sorry, I didn't get this.

(In reply to comment #5)
> In what way is Evolution broken in other desktop environments?

It's not only about evolution, it's about all single gtk application. There used to be a global option to decide whether the icons on buttons and menus should be shown for *all* gtk+ applications, but you dropped it with no explanation. Your "use a property on each single widget yourself" pseudo-replacement is ridiculous, making a room for "each application will look differently, based on author's choice, instead of user's choice", not talking about extra code/changes involved here for *each single gtk+ application*.

By the way, replying with question on question is considered rude, sometimes.
Comment 7 Milan Crha 2013-10-03 06:57:12 UTC
ping William Jon McCann.
Comment 8 Olivier Brunel (jjacky) 2013-10-07 23:51:23 UTC
Any news on this? GTK+3.10 is basically breaking (user experience of) every GTK application, GNOME or not, and the only "fix" seems to have to update every single application (so each add code to re-implement what was removed from GTK, simply because GNOME devs didn't want to use it in GNOME anymore...?)
Comment 9 multixrulz 2013-10-09 07:10:38 UTC
I'd like to add my support to re-enable user selection of button and menu icons in GTK+, even if GNOME choses to force it off.  I don't use GNOME but I do use GTK+ apps and find it harder to navigate them without these icons.  This can only lead to fragmentation among GTK+ apps and ruin the user experience.
Comment 10 Ulukai 2013-10-09 21:21:20 UTC
In name of the Arch Linux community, please bring back the icons in menus and on buttons. You started quite some controversy with this move. Read our frustrations in this thread: https://bbs.archlinux.org/viewtopic.php?pid=1335368#p1335368
Comment 11 Pedro Martinez-Julia 2013-10-09 22:53:52 UTC
I think that GTK users and developers are not being heard, much less asked, on this matter. In fact, if we (users and developers) join forces, we could have a small fork of GTK 3.x and try to keep it up-to-date by adding future changesets but skiping those changesets that remove icons in menus (and maybe other annoying changes like this).
Comment 12 Emmanuele Bassi (:ebassi) 2013-10-09 22:57:30 UTC
(In reply to comment #11)
> I think that GTK users and developers are not being heard, much less asked, on
> this matter.

Bugzilla is not the place to discuss. please, join gtk-devel-list and participate in the discussion there.
Comment 13 Pedro Martinez-Julia 2013-10-09 23:11:52 UTC
It was not a discussion but a (somewhat desperate) request for clarification about what will happen with this problem. I will not reply anymore nor give any reason for keeping or removing the capability. If you need any test-case or patch sketch, please let me know. Thank you.
Comment 14 Thomas Martitz 2013-11-06 13:58:57 UTC
I can't understand this move.

I already questioned the default-to-off move for icons, but taking away the user's freedom to turn them back on their desire is absolutely beyond me. Why do GTK+ devs do that?

I do like icons in my menus, why can't you simply respect that and at least keep the setting? It doesn't hurt you does it?
Comment 15 Pedro Martinez-Julia 2013-11-06 14:09:48 UTC
More and more apps are escaping from GTK+ because of such kind of decisions.

I do not know if this is intended by GNOME developers but they did it well in the past by keeping separate basic toolkit (libgtk) and desktop-specific widgets (libgnome), with all this means. Today, libgtk is evolving to meet just GNOME needs, and this is not good for other applications, so they are moving to other toolkits, with the (little but noticeable) inconveniences it means for GNOME users.
Comment 16 Emmanuele Bassi (:ebassi) 2013-11-06 14:30:41 UTC
it helps if, before leaving a comment, people look at the commit log *and* the mailing list. in this particular case, commits:

https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-10&id=a653b1b36bf4e55a5ba00708476a61c2bf5a1090
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-10&id=8ee2c87acbccadf9d300b9891ce4aa9e02fda7eb

and the email at: https://mail.gnome.org/archives/gtk-devel-list/2013-October/msg00166.html

clarify that the GtkImageMenuItem and GtkButton widgets continue to honour the gtk-button-images and gtk-menu-images settings.

closing this bug as fixed.
Comment 17 Matthias Clasen 2013-11-07 01:45:39 UTC
It is best to keep these interpretations out of bugzilla - nobody is going to reply to them here.
Comment 18 Thomas Martitz 2013-11-07 10:07:04 UTC
What do we need to change (which tool? which settings key?) to get the icons back? The commits suggest that I can do so via xsettings but I don't know how to accomplish this (I use archlinux and cinnamon).
Comment 19 Pedro Martinez-Julia 2013-11-07 10:20:39 UTC
Derived applications from gnome-settings-daemon (like cinnamon-settings-daemon) are capable of doing "xsettings". Other users may use "xsettingsd" to set custom settings without needing a full desktop.
Comment 20 Thomas Martitz 2013-11-07 10:26:06 UTC
The checkbox in the cinnamon system settings has no effect, so either Arch's GTK doesn't contain these commits yet or cinnamon does not do xsettings properly.

Is there some way to do it via command line? [1] suggests I can do with a settings.ini files in $HOME/.config/gtk-3.0 but I tried without success?

I tried 

$ cat settings.ini 
[Gtk]
MenuImages = True

and

$ cat settings.ini 
Gtk/MenuImages = True


[1] https://developer.gnome.org/gtk3/3.10/GtkSettings.html#GtkSettings.description
Comment 21 Thomas Martitz 2013-11-07 10:51:42 UTC
Alright,

[Settings]
gtk-menu-images = true

works. However the GTK+ in arch is at 3.10.2 which does not include the above commits. I guess we have to wait for 3.10.3. Is it going to be released?
Comment 22 Khurshid Alam 2014-01-31 21:28:34 UTC
Can anyone explain here why gtk-icon-sizes which was removed from gtk-3.10 can't be patched back?
Comment 23 Matthias Clasen 2014-02-03 13:45:27 UTC
(In reply to comment #21)

> works. However the GTK+ in arch is at 3.10.2 which does not include the above
> commits. I guess we have to wait for 3.10.3. Is it going to be released?

we're up to 3.10.7 by now. Talk to the arch maintainer...
Comment 24 Thomas Martitz 2014-02-03 13:53:35 UTC
You quoted an old comment. By now Arch linux is at 3.10.7 too.