GNOME Bugzilla – Bug 708031
telephatyIdle: Time stamps next conversation line
Last modified: 2014-02-17 19:26:36 UTC
Give more context to the chat notification bubble, put the time stamp next to the last conversation line instead of a new line
Created attachment 254865 [details] [review] telephatyIdle: Time stamps next conversation line To give more context to the chat notification bubble, put the time stamp next to the last conversation line instead of a new line.
Created attachment 254866 [details] Timestamp next to converstaion line
Uhm... so a timestamp for each line, including consecutive runs from the same person? Is this by design? (Also, is this UI freeze worthy? I personally don't think so)
It also breaks string freeze, which is unfortunate, but a no-go at this point.
(In reply to comment #3) > Uhm... so a timestamp for each line, including consecutive runs from the same > person? > Is this by design? > > (Also, is this UI freeze worthy? I personally don't think so) Ei, sorry for the confusion, it was just to show designers how it looks, (so I change temporaly to do the screenshot the timestamp timeout to 10 seconds) But no, just only when needed. um, so commit after freeze?
(In reply to comment #4) > It also breaks string freeze, which is unfortunate, but a no-go at this point. it is so bad? I mean, can we just put it for commit after freeze? or is there a problem?
Review of attachment 254865 [details] [review]: ::: js/ui/components/telepathyClient.js @@ +975,3 @@ + // Get the boxLayout of the last conversation line and add + // the timestamp next the conversation line + let messageBoxLayout = this._history[0].actor.get_parent(); ugh, why can't you just use lastGroupActor?
Created attachment 268567 [details] [review] telephatyIdle: Time stamps next conversation line To give more context to the chat notification bubble, put the time stamp next to the last conversation line instead of a new line.
Since we don't have lastGroupActor anymore, I added a new var called lastMessageBox.
Review of attachment 268567 [details] [review]: Looks good just them one string should probably be translateable. ::: js/ui/components/telepathyClient.js @@ +945,3 @@ // Show only the hour if date is on today if(daysAgo < 1){ + format = "%H:%M"; Why is this not translate able? If this is the intent then use single quotes.
Attachment 268567 [details] pushed as fff2ca6 - telephatyIdle: Time stamps next conversation line