After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707466 - Some timestamp fixes
Some timestamp fixes
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
wayland
Depends on:
Blocks:
 
 
Reported: 2013-09-04 13:35 UTC by Giovanni Campagna
Modified: 2014-02-24 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: use the timestamps from events (2.00 KB, patch)
2013-09-04 13:35 UTC, Giovanni Campagna 		accepted-commit_now Details | Review
display: shortcut get_time_roundtrip() when running as a wayland compositor (2.36 KB, patch)
2013-09-04 13:35 UTC, Giovanni Campagna 		accepted-commit_now Details | Review

Description Giovanni Campagna 2013-09-04 13:35:02 UTC 
That rely on clutter bug 706543.
Nothing critical (except for the clutter bug, unless we reintroduce the
hackish patch in gnome-shell), just nice to have.
Comment 1 Giovanni Campagna 2013-09-04 13:35:04 UTC 
Created attachment 254071 [details] [review]
wayland: use the timestamps from events

Clutter has learned to use monotonic times for the events, and
so does X (at least Xwayland, which is an implementation we know
and we can rely upon), so the values are directly comparable.
Comment 2 Giovanni Campagna 2013-09-04 13:35:08 UTC 
Created attachment 254072 [details] [review]
display: shortcut get_time_roundtrip() when running as a wayland compositor

In wayland, we can make some assumptions about the behavior and
configuration of the X server (which is Xwayland), including on
the time it uses, and that way avoiding a roundtrip (potentially deadly, if
by chance the X server is also blocking on us or needs us to flush
the wayland socket buffer).
Note that we bypass get_current_time() entirely, as it is assumed
the function is called always to translated CurrentTime into a real
value.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-09-04 14:19:49 UTC 
Review of attachment 254071 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-09-04 14:20:41 UTC 
Review of attachment 254072 [details] [review]:

typo in commit message: "called to translated"
Comment 5 Giovanni Campagna 2014-02-24 17:58:26 UTC 
It appears this was fixed long ago, but we forgot to close it.