After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705351 - account: Make sure we check for NULL on um_realm_object_get_common
account: Make sure we check for NULL on um_realm_object_get_common
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-02 13:20 UTC by Michael Wood
Modified: 2015-02-25 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check for NULL on um_realm_object_get_common (3.22 KB, patch)
2015-02-25 13:38 UTC, Ondrej Holy 		needs-work Details | Review
check for NULL on um_realm_object_get_common (3.18 KB, patch)
2015-02-25 14:44 UTC, Ondrej Holy 		committed Details | Review

Description Michael Wood 2013-08-02 13:20:08 UTC 
https://bugzilla.gnome.org/show_bug.cgi?id=705274
Comment 1 Ondrej Holy 2015-02-25 13:38:22 UTC 
Created attachment 297873 [details] [review]
check for NULL on um_realm_object_get_common
Comment 2 Rui Matos 2015-02-25 14:20:25 UTC 
Review of attachment 297873 [details] [review]:

::: panels/user-accounts/um-account-dialog.c
@@ +800,3 @@
+                show_error_dialog (self, _("Failed to register account"), NULL);
+                finish_action (self);
+                g_object_unref (self);

This g_object_unref() doesn't belong here.

It's already handled on the code that calls this function, in fact if we hit this path, then we'll doubly unref self.
Comment 3 Ondrej Holy 2015-02-25 14:44:50 UTC 
Created attachment 297882 [details] [review]
check for NULL on um_realm_object_get_common

You are right, thanks for review!
Comment 4 Rui Matos 2015-02-25 14:46:13 UTC 
Review of attachment 297882 [details] [review]:

ok
Comment 5 Ondrej Holy 2015-02-25 14:52:24 UTC 
Comment on attachment 297882 [details] [review]
check for NULL on um_realm_object_get_common

commit 3e6b741ad2cc749040ec073098aa9a7fb1a8c222