GNOME Bugzilla – Bug 704178
drop GtkStock
Last modified: 2013-07-19 13:38:05 UTC
See patches.
Created attachment 249086 [details] [review] background: drop GtkStock
Created attachment 249087 [details] [review] color: drop GtkStock
Created attachment 249088 [details] [review] network: drop GtkStock
Created attachment 249089 [details] [review] online-accounts: drop GtkStock
Created attachment 249090 [details] [review] bluetooth: drop GtkStock
Created attachment 249091 [details] [review] printer: drop GtkStock
Created attachment 249092 [details] [review] search: drop GtkStock
Created attachment 249093 [details] [review] sound: drop GtkStock
Created attachment 249095 [details] [review] wacom: drop GtkStock
Created attachment 249096 [details] [review] user-accounts: drop GtkStock
Review of attachment 249086 [details] [review]: Looks good.
Review of attachment 249087 [details] [review]: Looks good
Review of attachment 249088 [details] [review]: Looks good.
Review of attachment 249089 [details] [review]: Looks good.
Review of attachment 249090 [details] [review]: Looks good.
Review of attachment 249091 [details] [review]: Looks good.
Review of attachment 249092 [details] [review]: Looks good.
Review of attachment 249093 [details] [review]: Looks good.
Review of attachment 249095 [details] [review]: Looks good.
Review of attachment 249096 [details] [review]: ::: panels/user-accounts/um-fingerprint-dialog.c @@ +272,2 @@ button = gtk_button_new_with_mnemonic (_("_Delete Fingerprints")); + gtk_button_set_image (GTK_BUTTON (button), gtk_image_new_from_icon_name ("edit-delete", GTK_ICON_SIZE_BUTTON)); This needs removing the GTK_STOCK_DELETE docs say: GTK_STOCK_DELETE has been deprecated since version 3.10 and should not be used in newly-written code. Do not use an icon. Use label "_Delete".
Created attachment 249626 [details] [review] user-accounts: drop GtkStock
Review of attachment 249626 [details] [review]: Looks good.
Review of attachment 249086 [details] [review]: pushed as 27e12bb7b0b679fc21b6c5e21adb4ac6ed87ecb9 - background: drop GtkStock
Review of attachment 249087 [details] [review]: pushed as 972648fd5fa3cf1bdf1ab17e99d079ab6219a655 - color: drop GtkStock
Review of attachment 249088 [details] [review]: pushed as e611930dfb8d8d319f6e339a48d9de161e7dc42e - network: drop GtkStock
Review of attachment 249089 [details] [review]: pushed as a9f6f69f7029e8d00da6ce64baa3b1b33912aa36 - online-accounts: drop GtkStock
Review of attachment 249090 [details] [review]: pushed as 888db9b45382db0a5d1fdbb7f703ad2216d3cc41 - bluetooth: drop GtkStock
Review of attachment 249091 [details] [review]: pushed as d49a097b3e57d1d7a7f2e530c9357fc98ce70d5b - printer: drop GtkStock
Review of attachment 249092 [details] [review]: pushed as 6926cf08b9b1c8be0e0c207f85aa917ce2581db3 - search: drop GtkStock
Review of attachment 249093 [details] [review]: pushed as 4fc66a57fad8bca77fd091e8f2f772180726e13a - sound: drop GtkStock
Review of attachment 249095 [details] [review]: pushed as cf81bc227f1ff1784a5f5a04cc58f61786d8eb53 - wacom: drop GtkStock
Review of attachment 249626 [details] [review]: pushed as 0ca97710796874fd0ba29a07184c3c68f796ea08 - user-accounts: drop GtkStock