GNOME Bugzilla – Bug 703865
Add GdKeyShortcutButton to capture keyboard shortcuts
Last modified: 2015-03-03 12:54:43 UTC
This is based in the patch for adding a GtkKeyShortcutButton as found in the bug https://bugzilla.gnome.org/show_bug.cgi?id=703038 . This is, however, a stripped version of that widget because it was using some private things from GTK+ that had to be removed and, with it, one of the modes that the widget supports. In case this button should be integrated in GTK+ one day, please use the patch in the bug mentioned above.
Created attachment 248718 [details] [review] Add GdKeyShortcutButton to capture keyboard shortcuts
Why do you need this in libgd? Since we're moving the bulk of the widgets from libgd to GTK+ proper, I'd rather avoid adding new classes in there at this point.
I would also rather it was a gtk widget so that most of that code could be shared with the cell renderer through private API.
Created attachment 248830 [details] [review] Add GdKeyShortcutButton to capture keyboard shortcuts This new versions adds the key-shortcut-button keyword to the README.
FWIW, I think that this is a useful widget for GTK+ and I also think it should rather be there than in libgd. As for sharing some internal code with gtkcellrendereraccel. Might be because I copied many things but from what I talked with Benjamin Otte and Matthias Clasen, the renderer shouldn't be touched.
(In reply to comment #5) > FWIW, I think that this is a useful widget for GTK+ and I also think it should > rather be there than in libgd. OK, should we close this as INVALID/WONTFIX and move the discussion to bug 703038 then?
Closing as WONTFIX as I don't see any opposition to inclusion in GTK+.