GNOME Bugzilla – Bug 702565
Load cover art on scroll in Albums and Artists view
Last modified: 2014-04-28 11:08:38 UTC
We should load the cover art once the user scrolls to them to minimize the amount of background tasks at populate.
Created attachment 247155 [details] [review] Implementation on Albums view Haven't check this much, so probably not good for commit yet. I might move the loading from ViewContainer to AlbumsView because ViewContainer is also used for the left pane of Artists view. That code is unnecessary there. Don't know if I should override _onScrolledWinChange (I'm new to JS), because it seems like it is supposed to be a private function. Also, I added a new column to the list store to know if loading the cover art is already queued. I haven't looked yet at the right pane of Artists view for loading on-scroll there. It doesn't use a GtkIconView, so implementation there would be different.
Review of attachment 247155 [details] [review]: Please rebase on top of latest master, it had some changes in adding in this._model.set due to libgd update This patch also breaks tests - hang up in tests_albumPlayback.js
Created attachment 248308 [details] [review] Load cover art on scroll in Albums view This will start the loading of cover art once the user scrolls to it, minimizing the amount of background tasks on populate.
Rebased the patch and moved loading on-load to the AlbumsView since it is not used on the other views. The test is still broken - we have to find a new way to detect if the first load of albums is already finished. I think this patch is ready for commit, we could fix the Artists view later (we could keep this bug open while that part is not yet finished).
Created attachment 248310 [details] [review] Load cover art on scroll in Albums view This will start the loading of cover art once the user scrolls to it, minimizing the amount of background tasks on populate.
Comment on attachment 247155 [details] [review] Implementation on Albums view Obsolete this. I updated the latest patch to remove a possible deadlock.
Review of attachment 248310 [details] [review]: Looks nice, but Albums view blinks each time a cover is being fetched
Created attachment 253369 [details] [review] Load thumbnails for visible elements only + 10 next
Review of attachment 253369 [details] [review]: Needs rebase to current master branch.
Rebased on master and pushed to https://git.gnome.org/browse/gnome-music/commit/?id=05b8bf2 (will appear in 3.13.1)