GNOME Bugzilla – Bug 699968
capsfilter: Send caps after segment if source has no caps
Last modified: 2013-05-09 07:33:31 UTC
The caps filter element will send caps after segment if source has no caps. Pipepline to reporduce: gst-launch fakesrc num-buffers=1 format=time ! capsfilter caps=video/h264 ! fakesink Currently, it will negotiate on first buffer, but maybe it should negotiate when the segment comes in.
Created attachment 243659 [details] [review] [PATCH] capsfilter: Send caps before segment In the case the source has no caps, caps must be sent before segment. This fixes few unit tests that where failing due to the new misordering warning. https://bugzilla.gnome.org/show_bug.cgi?id=699968 --- plugins/elements/gstcapsfilter.c | 43 +++++++++++++++++++++++++++++----------- 1 file changed, 31 insertions(+), 12 deletions(-)
This also makes all tests pass again in gstreamer core
Comment on attachment 243659 [details] [review] [PATCH] capsfilter: Send caps before segment (In reply to comment #2) > This also makes all tests pass again in gstreamer core Forget that, it failed on second try.
Created attachment 243670 [details] [review] [PATCH] capsfilter: Send caps before segment In the case the source has no caps, caps must be sent before segment. This fixes few unit tests that where failing due to the new misordering warning. https://bugzilla.gnome.org/show_bug.cgi?id=699968 --- plugins/elements/gstcapsfilter.c | 49 ++++++++++++++++++++++++++++++++++------ plugins/elements/gstcapsfilter.h | 1 + 2 files changed, 43 insertions(+), 7 deletions(-)
commit 98f6b75cd3ed0f1b49425c534759e69bf831054e Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Thu May 9 09:32:49 2013 +0200 capsfilter: Send all events that should happen after CAPS after the CAPS event commit c86f42bc88778d4638eff7428075893e7af2a62a Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> Date: Wed May 8 21:45:08 2013 -0400 capsfilter: Send caps before segment In the case the source has no caps, caps must be sent before segment. This fixes few unit tests that where failing due to the new misordering warning. https://bugzilla.gnome.org/show_bug.cgi?id=699968