After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699877 - Branding-schmanding
Branding-schmanding
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-07 20:47 UTC by Florian Müllner
Modified: 2013-05-07 22:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
modalDialog: Replace Shell.Stack with layout manager (1.36 KB, patch)
2013-05-07 20:47 UTC, Florian Müllner 		committed Details | Review
loginDialog: Adjust logoBin to modalDialog changes (1.11 KB, patch)
2013-05-07 20:47 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-05-07 20:47:11 UTC 
I only tested the branding patches from bug 694912 with jhbuild Clutter (e.g. clutter-1.16), which worked fine; unfortunately however, commit e98eb57e3e8b8 breaks modal dialogs horribly with the stable version from GNOME 3.8 (e.g. clutter-1.14). Attached patches fix should fix the problem for either clutter version (and are arguably better style anyway).
Comment 1 Florian Müllner 2013-05-07 20:47:14 UTC 
Created attachment 243538 [details] [review]
modalDialog: Replace Shell.Stack with layout manager

Commit e98eb57e3e8b added flags to expand the dialog's background
stack, which works fine with the current clutter-1.16 branch, but
breaks on clutter-1.14 (as shipped with GNOME 3.8).
Using an St.Widget with a Clutter.BinLayout fixes this, and is more
modern Clutter usage.
Comment 2 Florian Müllner 2013-05-07 20:47:18 UTC 
Created attachment 243539 [details] [review]
loginDialog: Adjust logoBin to modalDialog changes

With modalDialogs' backgroundStack using a BinLayout now, we need
to set approriate expand flags on the iconBin.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-05-07 22:04:28 UTC 
Review of attachment 243538 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-07 22:05:01 UTC 
Review of attachment 243539 [details] [review]:

OK.
Comment 5 Florian Müllner 2013-05-07 22:07:50 UTC 
Attachment 243538 [details] pushed as e2c86ce - modalDialog: Replace Shell.Stack with layout manager
Attachment 243539 [details] pushed as d920da6 - loginDialog: Adjust logoBin to modalDialog changes