After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699180 - user comments, move the user icon to the right, or out of the text frame.
user comments, move the user icon to the right, or out of the text frame.
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-28 20:52 UTC by Luc Pi
Modified: 2015-06-04 22:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move profile pic to action header (1.58 KB, patch)
2015-06-04 17:53 UTC, Alexandre Franke 		none Details | Review
Move profile pic to action header (1.70 KB, patch)
2015-06-04 18:24 UTC, Alexandre Franke 		committed Details | Review
Shows the patch in action. (35.01 KB, image/png)
2015-06-04 18:32 UTC, Alexandre Franke 		  Details

Description Luc Pi 2013-04-28 20:52:41 UTC 
in the module pages, in the conversation thread,
the user icon is pushing the ~3 first lines of text.
If you meant to have these lines aligned with the following, it messes it up.

==> move the icon to the right, or out of the text frame.

Example page:
https://l10n.gnome.org/vertimus/yelp-xsl/master/po/fr
Comment 1 Alexandre Franke 2015-06-02 20:49:06 UTC 
I'll try my hands at this once bug 750229 is done. I think moving the profile pic in the comment header next to the name makes more sense (both visually and semantically). Then I'll just have to rearrange the header content on two lines and fix the CSS to have the header box with correct margins.
Comment 2 Alexandre Franke 2015-06-04 17:53:05 UTC 
Created attachment 304605 [details] [review]
Move profile pic to action header
Comment 3 Alexandre Franke 2015-06-04 18:24:05 UTC 
Created attachment 304606 [details] [review]
Move profile pic to action header

I forgot that bit in the first version.
Comment 4 Alexandre Franke 2015-06-04 18:32:20 UTC 
Created attachment 304607 [details]
Shows the patch in action.
Comment 5 Alexandre Franke 2015-06-04 22:17:24 UTC 
Thanks for the quick review!

Attachment 304606 [details] pushed as 9ed41d6 - Move profile pic to action header