After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697893 - Don't insist on a password of any strength
Don't insist on a password of any strength
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-12 16:06 UTC by Michael Wood
Modified: 2013-04-17 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
account: Allow no password or weak password (5.81 KB, patch)
2013-04-12 16:06 UTC, Michael Wood 		reviewed Details | Review
account: Allow no password or weak password (4.97 KB, patch)
2013-04-12 16:44 UTC, Michael Wood 		accepted-commit_now Details | Review

Description Michael Wood 2013-04-12 16:06:42 UTC 
Created attachment 241367 [details] [review]
account: Allow no password or weak password

Related bug 679744 and bug 633015

Like Allan said we can help the user to create a strong password but we don't need to insist on it.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-04-12 16:19:48 UTC 
Review of attachment 241367 [details] [review]:

Looks good.

::: gnome-initial-setup/pages/account/gis-account-page.c
@@ +74,3 @@
   gboolean domain_chosen;
 
+  guint password_len;

What's the advantage of saving this?
Comment 2 Michael Wood 2013-04-12 16:44:48 UTC 
Created attachment 241371 [details] [review]
account: Allow no password or weak password

Ah the password_len storage was left over from a bit of re-factoring, removed now. Thanks.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-04-12 16:47:08 UTC 
Review of attachment 241371 [details] [review]:

Looks good, with a minor nit.

::: gnome-initial-setup/pages/account/gis-account-page.c
@@ +313,3 @@
+    set_entry_validation_error (GTK_ENTRY (password_entry), _("No password"));
+
+  if (strlen (password) > 0)

"else"?
Comment 4 Michael Wood 2013-04-12 17:26:01 UTC 
pushed as 23bf265c79ca170eefb81de0d6c923d577da3880 with above fixed
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-04-17 15:29:28 UTC 
*** Bug 679744 has been marked as a duplicate of this bug. ***