GNOME Bugzilla – Bug 696868
Register to Treeview - More options added
Last modified: 2018-06-29 23:14:31 UTC
Created attachment 240138 [details] [review] Register rewrite patch This is an update to the Possible Register migration to Treeview - 673193 As before, do not open same account register in old style and the tree-view one and it may also be required to delete the saved pages in gconf under register2 heading. The previous two updates need to be applied before these are, that is bug 696152 and bug 695773. The first patch adds print check, find, schedule and reconcile. This update changes adds the print check, find transactions, schedule transactions and reconcile options to the new register. This was done by copying the existing files and changing them to work with the new register so both new and old could work at the same time. The new find option on the accounts page has been commented out so the old one would work but has been proved to work the same as on the new registers. Also have the refresh option working which involves reloading the register by re-running the query which is also used for the search register updates. To allow the search and general ledgers use different columns, I had to specify a new guid of '0......1' for the general ledger in gnc-split-reg2 and the search register uses the default of '0......0'. Also I corrected what I thought was a bug in that if you start a search from the general register, the results would over write the general ledger page.
Created attachment 240139 [details] [review] Register rewrite patch This second patch adds date accelerator and fixes duplicate transaction. This update adds the date accelerator keys to the date column. There is one strange thing that I can not work out to do with the cell focus. On clicking the cell, existing entry highlights and you should be able to use the left arrow key to move to the beginning of the cell but this just moves you away from the cell. If you were to click again or use a valid key, it would work. This points to my cell renderer date but can not see what at the moment as the action call back works but it will not set the focus to the entry properly.
Review of attachment 240139 [details] [review]: Most of the accelerator keys I know work as advertised. There is just one visual glitch that may need to be investigated: when an accelerator key is used, the date is updated, but the selection indication is gone (on my system selected text is highlighted in blue). I mean the date no longer appears selected. When I then hit a modifier key (like alt key) without any other key, the date is selected. A subsequent accelerator key action drops the selection again (can be with or without modifier key). The net result is some inconsistent selection state of the date. From a usability point of view, the date should be fully selected after an accelerator action. That's what the previous behaviour was (breaking user habits is expensive) and it makes it easier to change your mind and type in a date instead of using the accelerators.
I haven't verified the other patch yet. Will do that sometime later.
Hopefully fixed the visual glitch in 698899.
The other patch seems to be working fine as well. Closing this report.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=696868. Please update any external references or bookmarks.