Created attachment 241192 [details] [review]
auth-dialog: port to libsecret

Created attachment 241193 [details] [review]
auth-dialog: port to libsecret

Created attachment 241194 [details] [review]
auth-dialog: port to libsecret

Created attachment 241195 [details] [review]
auth-dialog: port to libsecret

Created attachment 241196 [details] [review]
auth-dialog: port to libsecret

First off the only part of the patches that identifies which plugin it's for is the Makefile.am patch hunks...  but anyway.

Are we concerned about the loss of gnome_keyring_memory_strdup() and gnome_keyring_memory_free()?  From the look of it, nothing will zero out the memory after freeing the passwords.

Also, make sure you remove auth-dialog/vpn-password-dialog.c from POTFILES.in in all the plugins that have it.  Otherwise 'make distcheck' breaks.

Review of attachment 241193 [details] [review]:

Some indent issues, that's all.

::: auth-dialog/main.c
@@ +74,3 @@
+									   SECRET_SEARCH_ALL | SECRET_SEARCH_UNLOCK | SECRET_SEARCH_LOAD_SECRETS,
+									   NULL, NULL);
+	if (list && list->data) {

Indent here is off.

@@ +81,3 @@
+			secret = g_strdup (secret_value_get (value, NULL));
+			secret_value_unref (value);
+        }

This brace is mis-indented.

Review of attachment 241194 [details] [review]:

::: auth-dialog/main.c
@@ +83,3 @@
+			secret = g_strdup (secret_value_get (value, NULL));
+			secret_value_unref (value);
+        }

Indent issues.

Review of attachment 241195 [details] [review]:

::: auth-dialog/main.c
@@ +81,3 @@
+			secret = g_strdup (secret_value_get (value, NULL));
+			secret_value_unref (value);
+        }

indent issues.

Review of attachment 241196 [details] [review]:

::: auth-dialog/main.c
@@ +81,3 @@
+			secret = g_strdup (secret_value_get (value, NULL));
+			secret_value_unref (value);
+        }

indent issues

So basically, for all the patches only indent issues need to be fixed.

(In reply to comment #7)
> Also, make sure you remove auth-dialog/vpn-password-dialog.c from POTFILES.in
> in all the plugins that have it.  Otherwise 'make distcheck' breaks.

Ignore that, leftover from the vpn password dialog consolidation.  I'm fixing.

(In reply to comment #6)
> Are we concerned about the loss of gnome_keyring_memory_strdup() and
> gnome_keyring_memory_free()?  From the look of it, nothing will zero out the
> memory after freeing the passwords.

yeah, but the GtkEntry is going to "leak" its copy of the password too. And the shell will probably leak multiple copies of the string as it gets passed to and from JS.

pushed