GNOME Bugzilla – Bug 693783
wip/locale-info squashed patch
Last modified: 2013-02-19 11:24:55 UTC
Created attachment 236033 [details] [review] squashed patch from wip/locale-info Here's the squashed patch from the wip/locale-info branch to make it easier to review.
Review of attachment 236033 [details] [review]: Looks fine overall. ::: libgnome-desktop/default-input-sources.h @@ +6,3 @@ +} DefaultInputSource; + +static DefaultInputSource default_input_sources[] = Add some details about the source of this information somewhere. ::: libgnome-desktop/gnome-languages.h @@ +43,3 @@ +char * gnome_normalize_locale (const char *locale); +gboolean gnome_language_has_translations (const char *code); +char * gnome_get_language_from_code (const char *code, "code" being? "language code"? "country code"? which ISO? ::: libgnome-desktop/gnome-xkb-info.c @@ +306,3 @@ + if (!priv->current_parser_layout->xkb_name) + { + g_set_error (error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT, This seems to be unrelated bug fixes, make sure to split.
(In reply to comment #1) > Review of attachment 236033 [details] [review]: > > Looks fine overall. > > ::: libgnome-desktop/default-input-sources.h > @@ +6,3 @@ > +} DefaultInputSource; > + > +static DefaultInputSource default_input_sources[] = > > Add some details about the source of this information somewhere. Ok, I edited the commit message. > ::: libgnome-desktop/gnome-languages.h > @@ +43,3 @@ > +char * gnome_normalize_locale (const char *locale); > +gboolean gnome_language_has_translations (const char *code); > +char * gnome_get_language_from_code (const char *code, > > "code" being? "language code"? "country code"? which ISO? It's specified in the gtk-doc comment. Being language_from_code is IMO clear that it's a language code. > ::: libgnome-desktop/gnome-xkb-info.c > @@ +306,3 @@ > + if (!priv->current_parser_layout->xkb_name) > + { > + g_set_error (error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT, > > This seems to be unrelated bug fixes, make sure to split. Not really, the problem is that, given the way the parser is structured, we need to make sure we already have the current layout name so that we can look it up in the hash table.
Created attachment 236585 [details] [review] squashed patch from wip/locale-info Rebased the wip/locale-info branch on master and re-diffed the patch.
Review of attachment 236585 [details] [review]: Looks fine.
Comment on attachment 236585 [details] [review] squashed patch from wip/locale-info pushed all the individual patches plus a soname bump