GNOME Bugzilla – Bug 693658
Use sidecar files for plug-ins
Last modified: 2016-04-12 19:20:53 UTC
This enables us to not even load the plugin if it's disabled and prevent loading of concurrent versions of e.g. GStreamer. Currently disabled plug-ins are not even unloaded and we can only know if the plugin should be enabled/disabled upon loading it
With "sidecar" meaning some accompanying text file describing the plug-in's properties.
should be enhancement, not trivial
Created attachment 242318 [details] [review] all: Add sidecar file support for plugins Install a .plugin file with each plugin that provides some meta-information about the plugin, allowing us to not load the module if the user has disabled it instead blindly loading each .so we come across and let the module check whether it's enabled or not
Review of attachment 242318 [details] [review]: Found two typos. ::: src/librygel-core/rygel-plugin-information.vala @@ +24,3 @@ + * Parse plugin sidecar file and provide path to the module. + * + * Sidecar files are keyfiles, losely compatible with the files used by s/losely/loosely @@ +27,3 @@ + * libpeas. + * + * A minimum file looks like this: s/minimum/minimal
Comment on attachment 242318 [details] [review] all: Add sidecar file support for plugins Patch committed with comments fixed Attachment 242318 [details] pushed as a68c54a - all: Add sidecar file support for plugins
Heh, removed two typos just to add a new one. :) "A minimal file for the plugin librygel-sompelugin.so looks like this:" ^^^^^^^^^^
Well, good ratio, it goes down ;)
This fails make install for me: gtk-doc fails to use {{{ and }}} as code block markers properly. I get a </programlisting> end marker without a start marker in the xml. As a result the html is not generated. The docs for gtk-doc seem to say |[ and ]| are the right way to mark code blocks... that fixes make install but for some reason I end up with the whole example in one single code line. Grrr.
And the bug link I should have included: bug 727219