GNOME Bugzilla – Bug 693653
sharing: add a master switch to allow disabling of all services
Last modified: 2013-02-19 10:05:31 UTC
Add a master switch to allow disabling of all services.
Created attachment 235778 [details] [review] sharing: add a master switch to allow disabling of all services
Got the UI mockup for this?
(In reply to comment #2) > Got the UI mockup for this? https://live.gnome.org/Design/SystemSettings/Sharing The mockups do not show the "Enabled" string, but I have added it to be consistent with other panels that have this feature (e.g. Search). I expect this to change when the panel titles appear in the toolbar (bug 692174).
Review of attachment 235778 [details] [review]: UI looks good, but the error paths aren't working so well. I have "Personal File Sharing", "Screen Sharing" and "Remote Login" all "On". Clicking on the switch asks me for my password to disable the remote login. If this fails, all the services but "remote login" are disabled and the switch stays "Enabled". The error path should include restoring the services to their prior state (and possible start by disabling the ones that can fail).
Created attachment 236644 [details] [review] sharing: add a master switch to allow disabling of all services
(In reply to comment #5) > Created an attachment (id=236644) [details] [review] > sharing: add a master switch to allow disabling of all services This patch adds restoring services to their previous state if the master switch is re-activated.
The patch pushed does not include re-enabling of services, since the user may not expect the services to be enabled after one of them failed to be disabled. The patch also has the "Enabled" label removed, since bug 692174 has now been resolved.