After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692414 - Move gdm-languages to gnome-desktop as gnome-languages
Move gdm-languages to gnome-desktop as gnome-languages
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 692413
Blocks:
 
 
Reported: 2013-01-23 19:08 UTC by Rui Matos
Modified: 2013-01-25 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure: Move gnome-desktop-3.0 to COMMON_MODULES (4.09 KB, patch)
2013-01-23 19:08 UTC, Rui Matos 		rejected Details | Review
common: gdm-languages moved to gnome-desktop as gnome-languages (61.58 KB, patch)
2013-01-23 19:08 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-01-23 19:08:44 UTC 
See patches.
Comment 1 Rui Matos 2013-01-23 19:08:48 UTC 
Created attachment 234242 [details] [review]
configure: Move gnome-desktop-3.0 to COMMON_MODULES

This is required by 9 panels currently so it might as well go into
common modules.
Comment 2 Rui Matos 2013-01-23 19:08:53 UTC 
Created attachment 234243 [details] [review]
common: gdm-languages moved to gnome-desktop as gnome-languages

That code is useful for other core desktop modules.
Comment 3 Bastien Nocera 2013-01-25 14:55:36 UTC 
Review of attachment 234242 [details] [review]:

I'd rather have the specific panels linked *only* to the libraries they do use. Makes it easier to drop the dependency for particular modules.
Comment 4 Bastien Nocera 2013-01-25 15:04:37 UTC 
Review of attachment 234243 [details] [review]:

++
Comment 5 Rui Matos 2013-01-25 15:43:06 UTC 
(In reply to comment #3)
> I'd rather have the specific panels linked *only* to the libraries they do use.
> Makes it easier to drop the dependency for particular modules.

Ok, let's leave that out.

Attachment 234243 [details] pushed as 7221f9c - common: gdm-languages moved to gnome-desktop as gnome-languages