After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688524 - Expose gtk-primary-button-warps-slider as an X setting
Expose gtk-primary-button-warps-slider as an X setting
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-11-17 11:03 UTC by Ron Yorston
Modified: 2017-05-05 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtk+: Expose gtk-primary-button-warps-slider as an X setting (1.02 KB, patch)
2012-11-17 11:03 UTC, Ron Yorston
none Details | Review
gsettings-desktop-schemas: Add a key for gtk-primary-button-warps-slider (1.06 KB, patch)
2012-11-17 11:05 UTC, Ron Yorston
none Details | Review
gnome-settings-daemon: Add warp-slider X setting (1.27 KB, patch)
2012-11-17 11:06 UTC, Ron Yorston
none Details | Review
Only add the XSetting (979 bytes, patch)
2016-01-25 19:04 UTC, Olav Vitters
committed Details | Review

Description Ron Yorston 2012-11-17 11:03:29 UTC
Created attachment 229222 [details] [review]
gtk+: Expose gtk-primary-button-warps-slider as an X setting

The style property gtk-primary-button-warps-slider controls how GtkRange behaves when the mouse is clicked in the trough.  Expose this as an X setting which can be configured as org.gnome.desktop.interface.warp-slider.
Comment 1 Ron Yorston 2012-11-17 11:05:25 UTC
Created attachment 229223 [details] [review]
gsettings-desktop-schemas: Add a key for gtk-primary-button-warps-slider
Comment 2 Ron Yorston 2012-11-17 11:06:44 UTC
Created attachment 229224 [details] [review]
gnome-settings-daemon: Add warp-slider X setting
Comment 3 Matthias Clasen 2012-11-20 00:08:57 UTC
Why should we do that ?
The setting is meant to adapt GTK+ to the platform it run on, not to expose an extra knob inside a single platform.
Comment 4 Ron Yorston 2012-11-20 12:23:18 UTC
Why? So that users can configure the paging behaviour of scrollbars in the same way that other aspects of the UI are configurable.
Comment 5 Cosimo Cecchi 2012-11-20 16:29:39 UTC
Unless I'm missing something, I believe this can be overridden by just adding the following in ~/.config/gtk-3.0/settings.ini

gtk-primary-button-warps-slider = 1

I don't see the point to expose this through another two layers of settings (GSettings and XSettings).
Comment 6 Ron Yorston 2012-11-20 21:37:10 UTC
Editing settings.ini was the first thing I tried, but I couldn't get it to work.  Evidently I didn't try hard enough because after giving it another go it does now work for me.

Still, making it available via GSettings does provide alternative ways to configure it.
Comment 7 Cosimo Cecchi 2012-11-20 21:52:22 UTC
(In reply to comment #6)

> Still, making it available via GSettings does provide alternative ways to
> configure it.

It does indeed, but the question is whether we want to provide all these alternative ways of configuring something which is really a platform choice rather than an user setting.

I don't expect e.g. the control center to ever get any UI to configure this, and tools like gnome-tweak-tool can easily modify settings.ini. For instance gnome-tweak-tool already does a very similar thing for an "use dark theme everywhere" option.

I think I would close this as WONTFIX, but Matthias might want to have a final call.
Comment 8 Olav Vitters 2016-01-24 15:40:07 UTC
I'd like _only_ patch #1 to go in to allow for:
- gtk+3 under GNOME 3 to behave as is
- gtk+3 under KDE (with xsettings-kde) to behave more like KDE


Modifying settings.ini will change the behaviour everywhere. This is pretty much why xsettings were invented, no? I'd prefer the xsetting name "Gtk/PrimaryButtonWarpsSlider"
Comment 9 Matthias Clasen 2016-01-25 13:39:46 UTC
Whenever I've interacted with KDE, they've been unwilling to export settings if they have Gtk/ in their name, so I don't think making this an XSetting is going to help you.
Comment 10 Olav Vitters 2016-01-25 19:04:03 UTC
Created attachment 319703 [details] [review]
Only add the XSetting

As discussed on IRC. Note: I am a new xsettings-kde developer with Git+SVN access :-D
Comment 11 Matthias Clasen 2016-01-26 13:53:49 UTC
Review of attachment 319703 [details] [review]:

ok
Comment 12 Olav Vitters 2016-01-26 18:24:05 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.