Bug 687961 – use of git submodules is broken

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 687961 - use of git submodules is broken


Summary:	use of git submodules is broken


Status:	RESOLVED INVALID

Product:	gnome-boxes
Classification:	Applications
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	--
Assigned To:	GNOME Boxes maintainer(s)
QA Contact:	GNOME Boxes maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-11-09 08:01 UTC by Allison Karlitskaya (desrt)
Modified:	2016-03-31 14:02 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Absolute path for libgd (561 bytes, patch) 2013-03-18 03:44 UTC, Pierre-Yves Luyten	rejected	Details \| Review

Description Allison Karlitskaya (desrt) 2012-11-09 08:01:08 UTC

gnome-boxes suffers from the same issue as in bug 687718

Comment 1 Pierre-Yves Luyten 2013-03-18 03:44:47 UTC

Created attachment 239089 [details] [review]
Absolute path for libgd

Same as https://git.gnome.org/browse/gnome-font-viewer/commit/?id=06d2d9930bf90fabab62c021784c12c7c9bd95a5

Comment 2 Christophe Fergeau 2013-03-18 09:33:29 UTC

Review of attachment 239089 [details] [review]:

Thanks for the patch!

Comment 3 Marc-Andre Lureau 2013-03-18 12:58:48 UTC

bogus, see my argument on #687718

Comment 4 Marc-Andre Lureau 2013-03-18 13:00:12 UTC

Review of attachment 239089 [details] [review]:

mark as rejected, as I am really not convinced by the arguments given by Ryan, quite the contrary.

Comment 5 Zeeshan Ali 2014-02-23 21:45:17 UTC

Based on comment#4.