After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686975 - totem-pl-parser has an automagic dependency on multiple gmime versions
totem-pl-parser has an automagic dependency on multiple gmime versions
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-27 10:35 UTC by Pacho Ramos
Modified: 2017-08-13 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Force-gmime-2.6-usage-to-prevent-automagic-dependenc.patch (986 bytes, patch)
2012-10-27 10:40 UTC, Pacho Ramos 		committed Details | Review

Description Pacho Ramos 2012-10-27 10:35:37 UTC 
As reported in:
https://bugzilla.gnome.org/show_bug.cgi?id=686510

Also totem-pl-parser is affected by this. Explained at:
http://www.gentoo.org/proj/en/qa/automagic.xml

totem-pl-parser is checking for gmime-2.4 and later gmime-2.6. If
both, gmime-2.4 and 2.6 are installed at compile time, tomboy will use
gmime-2.4 and, then, if later gmime-2.4 is removed due no package really
needing it (as, currently, nearly all packages are moved to support gmime-2.6
also), it will break.

Ideally, totem-pl-parser would have a "--with-gmime=[2.4,2,6]" configure option... but taken care gmime-2.2 is dead and the same will occur for 2.4, I think it doesn't deserve the effort and we could go for 2.6 usage (I can attach a trivial patch for this if you want).

Thanks
Comment 1 Pacho Ramos 2012-10-27 10:40:20 UTC 
Created attachment 227399 [details] [review]
0001-Force-gmime-2.6-usage-to-prevent-automagic-dependenc.patch
Comment 2 Pacho Ramos 2012-10-27 11:14:19 UTC 
Other option would be to check for newer version first based in current way or similar to the asterisk way of checking:
if test "x${PBX_GMIME}" = "x0" -a "${PKGCONFIG}" != "No"; then
        # Later versions of GMime use pkg-config
        for ver in 2.6 2.4 2.2 2.0; do
                if ! ${PKGCONFIG} --exists gmime-$ver; then
                        continue
                fi
                # If we got here, we have this version:
                GMIME_INCLUDE=$(${PKGCONFIG} gmime-$ver --cflags 2>/dev/null)
                GMIME_LIB=$(${PKGCONFIG} gmime-$ver --libs)
                PBX_GMIME=1
                AC_DEFINE([HAVE_GMIME], 1, [Define if your system has the GMIME libraries.])
                break;
        done
fi

If newer version is checked before older one, when we drop old version (due upstream deprecating it) we wouldn't need to rebuild packages to catch newer version
Comment 3 Pacho Ramos 2012-11-24 10:24:27 UTC 
any news on this?
Comment 4 Philip Withnall 2012-11-25 21:39:14 UTC 
Review of attachment 227399 [details] [review]:

Given that gmime 2.6 has been packaged in Ubuntu and Fedora for at least a year, I think it’s OK to just go with a hard dependency on 2.6. Please commit to master, thanks.
Comment 5 Pacho Ramos 2012-11-25 23:25:34 UTC 
(In reply to comment #4)
> Review of attachment 227399 [details] [review]:
> 
> Given that gmime 2.6 has been packaged in Ubuntu and Fedora for at least a
> year, I think it’s OK to just go with a hard dependency on 2.6. Please commit
> to master, thanks.

I don't have enough permissions to commit it myself :(
Comment 6 Bastien Nocera 2012-11-26 08:47:04 UTC 
Fixed the horrible commit message (use a text editor that warns you after 72 chars subjects please ;) and committed.

Thanks for the patch.