GNOME Bugzilla – Bug 686626
Remove ConsoleKit path
Last modified: 2014-04-25 13:58:23 UTC
Bug 686482 adds support for systemd in addition to ConsoleKit/upower for suspending. We should just remove the suspend support through ConsoleKit/upower.
Why?
Because gnome-settings-daemon doesn't support it anymore. See the discussion on d-d-l.
(In reply to comment #2) > Because gnome-settings-daemon doesn't support it anymore. See the discussion on > d-d-l. That discussion is far from over and decided. I won't be willing to remove the code path until we're all in agreement.
We'll certainly discuss this at the release team meeting next weekend. Please hold off on more code removal until then
Created attachment 275071 [details] [review] loginManager: Kill ConsoleKit support The code path is completely unmaintained and untested (and probably unused as well, considering that nobody has complained about accessing the session object's Active property which does not exist in the ConsoleKit case). Most of our ConsoleKit code is already a dummy anyway, just do the same for the remaining functionality.
Review of attachment 275071 [details] [review]: looks good ::: js/misc/loginManager.js @@ -218,3 @@ - // Having this function is a bit of a hack since the Systemd and ConsoleKit - // session objects have different interfaces - but in both cases there are - // Lock/Unlock signals, and that's all we count upon at the moment. I guess you can remove the copy of this comment further up in the systemd class too
Attachment 275071 [details] pushed as a244c1e - loginManager: Kill ConsoleKit support