Created attachment 226206 [details] [review]
messageTray: Do not add the tray unconditionally to ctrl-alt-tab

Commit 448517032e5de87 added the message tray unconditionally to
the Ctrl-Alt-Tab popup, but while this makes sense for a normal
session, we do not want it in the login screen.
Be a bit more careful where we make the tray available.

We should include this in 3.6.1.

Review of attachment 226206 [details] [review]:

Looks good.

Created attachment 226210 [details] [review]
messageTray: Do not add the tray unconditionally to ctrl-alt-tab

Woops, actually no - the original version didn't work properly, this one should work as expected ...

+1 from me

Review of attachment 226210 [details] [review]:

::: js/ui/messageTray.js
@@ +1503,3 @@
             }));
 
+        Main.sessionMode.connect('updated', Lang.bind(this, this._sessionModeUpdated));

This is usually spelt "_sessionUpdated"

@@ +1523,3 @@
+
+    _sessionModeUpdated: function() {
+        if (Main.sessionMode.isLocked || Main.sessionMode.isGreeter)

I don't believe Ctrl+Alt+Tab works in the lock screen, given that it's a modal keybinding and everything.

Attachment 226210 [details] pushed as d2e830c - messageTray: Do not add the tray unconditionally to ctrl-alt-tab