GNOME Bugzilla – Bug 684633
Add message tray to Ctrl-Alt-Tab
Last modified: 2012-10-03 16:05:11 UTC
In the overlay, a whole bunch of things appear in the Ctrl-Alt-Tab popup, including the message tray. Outside the overview, the popup has only the Top bar. Now that the message tray is keynavigatable, it should show up there too.
I asked rishi about this when it landed ( https://bugzilla.gnome.org/show_bug.cgi?id=681519#c8 ). I forget his reasoning, but it had to do with <Super>M.
Created attachment 224992 [details] [review] messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview Since the message tray is accessible outside of the overview, it doesn't make sense to show it only there.
Review of attachment 224992 [details] [review]: ::: js/ui/messageTray.js @@ +2054,3 @@ }); + // Don't move the windows up if we are in the overview. You still need to return early here.
Created attachment 225173 [details] [review] messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview Since the message tray is accessible outside of the overview, it doesn't make sense to show it only there.
Does this make sense for 3.6.1? Review?
Review of attachment 225173 [details] [review]: When activating the tray this way the currently focused window loses focus. That doesn't happen when activating it through dwelling or the hotkey.
Created attachment 225638 [details] [review] ctrlAltTab: Only set the stage focus mode when we're focusing a widget This ensures that we don't accidentally lose focus when switching to the message tray.
Review of attachment 225173 [details] [review]: Ok, the code looks fine and now works correctly with the other patch.
Review of attachment 225638 [details] [review]: Yes, this seems ok and works on all current ctrl+alt+tab users.
Attachment 225173 [details] pushed as 4485170 - messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview Attachment 225638 [details] pushed as a171e92 - ctrlAltTab: Only set the stage focus mode when we're focusing a widget