GNOME Bugzilla – Bug 683136
Implement new mockups for the Network Menu
Last modified: 2013-06-17 13:14:34 UTC
Meta bug to implement https://live.gnome.org/GnomeShell/Design/Guidelines/SystemStatus/Network and to keep togheter patches that don't have specific bugs.
Created attachment 223103 [details] [review] NetworkMenu: remove broken device activation policy Previously, when toggling a switch on we tried to replicate NM policy and find a good connection to activate. This is broken in many situations. Instead, only activate something when we can be sure it's what the user wants (i.e. when there is only one connection, or when there is none, and thus connecting will trigger the config dialog)
Created attachment 223104 [details] [review] [EXPERIMENTAL] PowerMenu: add a toggle switch for controlling mobile broadband card The network menu no longer allows to control power to the 3G cards. Place it in the power menu instead, and label it generically "Modem", as it controls data, SMS, GPS and possibly other services. Attached for design testing.
Review of attachment 223103 [details] [review]: Giovanni, please commit this patch, thank you ::: js/ui/status/network.js @@ +949,3 @@ return _("Wi-Fi"); else + return getDeviceName(this.device); Unrelated to policy changes. If intended, please split out.
Comment on attachment 223103 [details] [review] NetworkMenu: remove broken device activation policy Attachment 223103 [details] pushed as 82c8aad - NetworkMenu: remove broken device activation policy After short IRC discussion, we concluded this is desirable indepently of the rest of the network menu relayout.
what does the rest of the network menu relayout block on ?
This will be obsoleted by the combined system status menu, should we close it?
(In reply to comment #6) > This will be obsoleted by the combined system status menu, should we close it? Yes.