GNOME Bugzilla – Bug 682749
Update goffice locales picker
Last modified: 2012-09-27 09:57:22 UTC
The goffice/gtk/go-locale-sel.c file is in need of updating to the currently available locales. See the attached spreadsheet for a comparison of the lists. I'm not asking you to do this work, I'm interested in trying to provide a patch for it myself, but I need some guidance. Most of these are straightforward additions of new locales, but I have some questions: 1) I think these are easy enough to sort out, but I wanted to mention them. fix iw_IL to he_IL fix no_NO to nb_NO fix sr_YU to sr_RS eo_EO (no Esperanto locale in glibc), I'll just leave this alone for now. 2) How do you want to handle the Eurozone currency variants? br_FR br_FR@euro and many other pairs like this. 3) How do you want to handle script variants, like these and others? aa_ER aa_ER@saaho be_BY be_BY@latin gez_ER gez_ER@abegede gez_ET gez_ET@abegede ks_IN ks_IN@devanagari sd_IN sd_IN@devanagari tt_RU tt_RU@iqtelif uz_UZ uz_UZ@cyrillic
Created attachment 222503 [details] list of glibc versus goffice locales
1: trivial 2: I don't think we need that given the use we make of this selector 3: I don't know.
Thanks for the feedback Jean. I'm working on the patch, will post here when it is ready for review.
When available, it is possibly that this patch should be held until a patch for currency picker is also available. Refresh of country/currency strings in /goffice/utils/formats.c https://bugzilla.gnome.org/show_bug.cgi?id=682810
Created attachment 222605 [details] [review] Draft locale patch
Regional Geographic Classification questions Is Kazakhstan Asia or Eastern Europe? (currently set as Asia) Macedonia is currently Eastern Europe, should it be Western Europe? Moved a number of locales into previously unused LGroup LG_MIDDLE_EAST Created New LGroup: LG_CARIBBEAN Antigua and Barbuda/English (en_AG) Costa Rica (es_CR) Dominican Republic (es_DO) Puerto Rico (es_PR) Haiti/Kreyol (ht_HT) Aruba/Dutch (nl_AW) Netherland Antilles/Papiamento (pap_AN)
I'd say Kazakhstan is Asia and I'd keep Macedonia in Eastern Europe.
Then the patch as submitted should be good to go.
Applying the patch breaks the build: missing and misplaced commas. Fixed these. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Sorry for the patch errors. Thanks for the fix.