GNOME Bugzilla – Bug 679445
Add support for the upcoming GStreamer-1.0
Last modified: 2012-07-09 14:38:50 UTC
See patches. Porting to GStreamer 1.0 might become a GNOME goal (see https://live.gnome.org/GnomeGoals/PortToGstreamer1). The main patch still requires some work - this series allows gnome-shell to compile and run with either gst 0.10 or 1.0, but in the latter case the resulting video is corrupted.
Created attachment 218083 [details] [review] recorder-src: Use normal GObject boilerplate Gst will drop its own boilerplate in 1.0, so just use G_DEFINE_TYPE.
Created attachment 218084 [details] [review] recorder: Don't crash on pipeline errors In case of error, the recorder pipeline is reset to NULL, so don't access current_pipeline->src in that case.
Created attachment 218085 [details] [review] recorder: Optionally use gstreamer-1.0 Add optional support for the upcoming gstreamer-1.0 release; to test, build with --with-gst=1.0.
Created attachment 218086 [details] [review] recorder: Shut up warnings when compiling with gst-1.0 The GStreamer-1.0 API may still be subject to change, so for now there is a compiler warning when including the unstable gst header. Define GST_USE_UNSTABLE_API to omit the warning and not break compilation with -Werror.
( Have you seen https://bugzilla.gnome.org/show_bug.cgi?id=677434 ? )
Review of attachment 218083 [details] [review]: Sure.
Review of attachment 218084 [details] [review]: Sure.
Review of attachment 218085 [details] [review]: Not the biggest fan -- can we just switch support to gst-1.0 instead?
Review of attachment 218086 [details] [review]: Squash with the previous patch please.
(In reply to comment #8) > Review of attachment 218085 [details] [review]: > > Not the biggest fan -- can we just switch support to gst-1.0 instead? Not really, unless we leave the patch bitrotting in bugzilla until gstreamer-1.0 is actually released (a quick search for an ETA turns up "by the end of 2011", which was clearly missed, so I wouldn't rely on it to happen in the 3.6 timeframe). During the GTK+-3 transition, we used to have a gtk-compat.h file containing all the compatibility shims, we could do the same here instead of spreading GST_CHECK_VERSION() all over the place ...
Attachment 218083 [details] pushed as f9dbe56 - recorder-src: Use normal GObject boilerplate Attachment 218084 [details] pushed as f17fc43 - recorder: Don't crash on pipeline errors
Mmmh, so it looks[0] like we will get 1.0 in the 3.6 timeframe ... [0] http://lists.fedoraproject.org/pipermail/desktop/2012-July/007578.html
Is there something wrong with telling people to use 'jhbuild buildone gstreamer' for now?
Other than hurting Colin's feeling, of course.
(In reply to comment #13) > Is there something wrong with telling people to use 'jhbuild buildone > gstreamer' for now? More like 'jhbuild buildone gstreamer gst-plugins-{base,good,bad,ugly}', but no, nothing wrong with that as long as we get the 1.0 release in time for 3.6.
Created attachment 218102 [details] [review] recorder: Port to GStreamer 1.0 API GStreamer developers are currently finishing the 0.11 version, which will become 1.0. Port the screen recorder to the new API.
Review of attachment 218102 [details] [review]: Sure.
(In reply to comment #15) > (In reply to comment #13) > > Is there something wrong with telling people to use 'jhbuild buildone > > gstreamer' for now? > > More like 'jhbuild buildone gstreamer gst-plugins-{base,good,bad,ugly}', but > no, nothing wrong with that as long as we get the 1.0 release in time for 3.6. Rather: jhbuild buildone gstreamer-master gst-plugins-{base,good,bad,ugly}-master
Created attachment 218203 [details] [review] recorder: Port to GStreamer 1.0 API Minor update to actually produce correct videos.
Review of attachment 218203 [details] [review]: sure
Attachment 218203 [details] pushed as 460cda2 - recorder: Port to GStreamer 1.0 API