GNOME Bugzilla – Bug 679404
Read colors for message preview from Gtk theme
Last modified: 2013-09-13 01:06:35 UTC
Created attachment 218021 [details] Black text in HTML mail In between Evolution 3.4.3 and Evolution 3.5.3 the color of mail headers and HTML mail body text switched from being context sensitive to all-black. Before, the text was white on gray (it still is for plain text email), now it is black on gray.
Created attachment 218022 [details] Correct text color for text/plain
Created attachment 218934 [details] Impossible to determine the color displayed on that swatch
aklapper wrote in Bug #679810 > > - the Evolution fg color for HTML mails should be filed against Evolution > > In case you plan to file a separate ticket, please include information if that > specific HTML message uses CSS for defining colors. If it does, please retest > with unstable experimental Evolution version 3.5.x if possible. > CSS has never been supported before version 3.5 (which now uses WebKit instead > of ancient GtkHtml for rendering HTML messages). > Also please include your color setting under "Edit > Preferences > Mail > Preferences > General > Message Display > Highlight quotations with color". Too late. I tested 3.5.3 and there is no css in the message, just old-skool HTML. The email headers are also black. I cannot determine the quoting color because the new color choosing widget is super-dysfunctional. There’s no way to see what the selected color was. Another thing that was broken and fell by the wayside because in modern day Gnome a user with an insight is ignored. I cannot even use an eye dropper from that dialog on the swatch, because the eye dropper was also removed. I filed this before. Anyway, it’s light gray.
Created attachment 219020 [details] [review] Patch Set HTML text color from GtkStyle and remove some hardcoded text colors from CSS (to fix font colors in itip-view).
Patch looks good and mostly works, except of: a) "Retrieving message 'a'" is still black text on white background, which in dark theme makes it flashing horribly b) link color in dark theme is too dark, it's like Navy (dark blue), making email addresses effectively unreadable You also mention GtkStyle, it's deprecated these days, maybe reading colors from GtkStyleContext will fix b) on its own?
(In reply to comment #5) > b) link color in dark theme is too dark, it's like Navy (dark blue), making > email addresses effectively unreadable My link color is based on theme settings. Maybe your dark theme just have too low contrast? > > You also mention GtkStyle, it's deprecated these days, maybe reading colors > from GtkStyleContext will fix b) on its own? I checked both GtkStyle and GtkStyleContext docs but haven't found any way to get link colors...
OK, I tried with gtk3-demo on Hypertext and the link color doesn't seem to change, thus just let it be as is. I'm sorry for the noise with links.
Created attachment 219203 [details] [review] Fixed patch Fixes colors of "Retrieving message..." status message.
There is missing link color in e_mail_display_set_status(), leading to crash.
while not use link color in e_mail_formatter_get_html_header()? It makes more sense there, as "status" is just a message string.
Created attachment 219563 [details] [review] Fixed patch Interesting that it never crashed for me due to the missing color. Using e_mail_formatter_get_html_header() now.
Much better, thanks. One more thing, though: - selecting account node shows the empty preview panel as white rectangle Please fix that and commit. Thanks.
Oh, it is playing only with mailer, what about Contacts, Tasks and Memos view?
(In reply to comment #12) > - selecting account node shows the empty preview panel as white rectangle It displays empty document (without any HTML). WebKit does not apprently respect GtkStyle and renders empty canvas in white background. (In reply to comment #13) > Oh, it is playing only with mailer, what about Contacts, Tasks and Memos view? I considered other modules out of scope of this bug. Feel free to test it and open a new bug if it does not work there.
(In reply to comment #14) > (In reply to comment #12) > > - selecting account node shows the empty preview panel as white rectangle > > It displays empty document (without any HTML). WebKit does not apprently > respect GtkStyle and renders empty canvas in white background. I suppose passing empty HTML with colors set will make it for us. Please do that and commit. > (In reply to comment #13) > > Oh, it is playing only with mailer, what about Contacts, Tasks and Memos view? > > I considered other modules out of scope of this bug. Feel free to test it and > open a new bug if it does not work there. Evil bug #680666 filled.
Comment on attachment 219563 [details] [review] Fixed patch Committed to git master as 440e43d http://git.gnome.org/browse/evolution/commit/?id=440e43d2894fdd517cc91302d4364b082e7d1d8b