After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678816 - remoteSearch: Allow to reference .desktop file for Title/Icon
remoteSearch: Allow to reference .desktop file for Title/Icon
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-25 19:58 UTC by Florian Müllner
Modified: 2012-06-25 21:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remoteSearch: Use GIcon instead of icon name (1.49 KB, patch)
2012-06-25 19:58 UTC, Florian Müllner 		committed Details | Review
remoteSearch: Parse 'DesktopId' field in key file (2.43 KB, patch)
2012-06-25 19:58 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-06-25 19:58:50 UTC 
See patch.
Comment 1 Florian Müllner 2012-06-25 19:58:54 UTC 
Created attachment 217240 [details] [review]
remoteSearch: Use GIcon instead of icon name

Currently we pass an icon name for the 'icon' parameter of the
RemoteSearchProvider constructor. In hindsight, using a GIcon
instead will give us a bit more flexibility, so change it.
Comment 2 Florian Müllner 2012-06-25 19:58:57 UTC 
Created attachment 217241 [details] [review]
remoteSearch: Parse 'DesktopId' field in key file

We strongly expect applications to use the same values for the
'Title'/'Icon' fields in their search provider .ini file as the
'Name'/'Icon' fields in their .desktop file. Rather than requiring
applications to duplicate those fields, allow them to specify a
'DesktopId' field instead to point to the corresponding .desktop
file, which makes it possible to ship search provider files without
translatable strings (which is nice given that merging translations
into search provider files lacks a standard rule).
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-25 20:20:47 UTC 
Review of attachment 217240 [details] [review]:

Sure.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-06-25 20:20:56 UTC 
Review of attachment 217240 [details] [review]:

Sure.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-06-25 20:23:54 UTC 
Review of attachment 217241 [details] [review]:

LGTM.
Comment 6 Florian Müllner 2012-06-25 21:01:58 UTC 
Attachment 217240 [details] pushed as 4d77eb9 - remoteSearch: Use GIcon instead of icon name
Attachment 217241 [details] pushed as bc91b7d - remoteSearch: Parse 'DesktopId' field in key file