GNOME Bugzilla – Bug 678299
gst_base_sink_wait_eos and the GstBaseSink->wait_eos vfunc don't match
Last modified: 2012-06-18 09:45:03 UTC
The gst_base_sink_wait_eos function and the GstBaseSink->wait_eos virtual function don't match. It's not a simple case of arguments not lining up--AFAICT they perform different tasks. Beyond being difficult to deal with for Vala bindings (and likely others) this is just plain confusing, and it would be nice to get it changed before 1.0. I'm not familiar with GStreamer, but if someone could provide some guidance regarding what the API should be I'd be willing to write the patch.
commit 927f261b1c66892a497219675891255264d6b5d6 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Mon Jun 18 11:36:25 2012 +0200 basesink: wait_eos() -> wait() Rename gst_base_sink_wait_eos() to gst_base_sink_wait() to avoid confusion and introspection problems with the ::wait_eos vmethod. Also this method can be used to wait for other things than EOS. Update the docs a little.