GNOME Bugzilla – Bug 677948
[new roster] Use EmpathyRosterView
Last modified: 2012-06-15 11:44:37 UTC
Once bug #677947 has been fixed, the 'empathy' process should use the new contact list view.
Created attachment 216379 [details] [review] roster-window: use tp_g_signal_connect_object()
Created attachment 216380 [details] [review] roster-window: use EmpathyRosterView Lot of features have been disabled/commented out. I'll re-introduce them progressively.
Created attachment 216381 [details] [review] roster-window: hook activate and popup menu
Created attachment 216382 [details] [review] roster-window: display messages when roster is empty
Created attachment 216383 [details] [review] roster-window: display events in the view
Review of attachment 216379 [details] [review]: ++
Review of attachment 216380 [details] [review]: ++
Review of attachment 216381 [details] [review]: ::: src/empathy-roster-window.c @@ +2168,3 @@ + menu = empathy_individual_menu_new (individual, features, NULL); + + guint time, "takes" @@ +2169,3 @@ + + /* menu is initially unowned but gtk_menu_attach_to_widget() taked its + guint time, "for the view to release its ref" @@ +2170,3 @@ + /* menu is initially unowned but gtk_menu_attach_to_widget() taked its + * floating ref. We can either wait that the view releases its ref + gpointer user_data) "when it is destroyed" "explicitly"
Review of attachment 216382 [details] [review]: ++
Review of attachment 216383 [details] [review]: ++
(In reply to comment #8) > Review of attachment 216381 [details] [review]: > > ::: src/empathy-roster-window.c > @@ +2168,3 @@ > + menu = empathy_individual_menu_new (individual, features, NULL); > + > + guint time, > > "takes" > > @@ +2169,3 @@ > + > + /* menu is initially unowned but gtk_menu_attach_to_widget() taked its > + guint time, > > "for the view to release its ref" > > @@ +2170,3 @@ > + /* menu is initially unowned but gtk_menu_attach_to_widget() taked its > + * floating ref. We can either wait that the view releases its ref > + gpointer user_data) > > "when it is destroyed" > "explicitly" I failed at English, thanks :)
Attachment 216379 [details] pushed as c352f96 - roster-window: use tp_g_signal_connect_object() Attachment 216380 [details] pushed as 8ed2137 - roster-window: use EmpathyRosterView Attachment 216381 [details] pushed as 0d2c82e - roster-window: hook activate and popup menu Attachment 216382 [details] pushed as 97242a7 - roster-window: display messages when roster is empty Attachment 216383 [details] pushed as a3c513e - roster-window: display events in the view