After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677289 - Removable drive menu this._manager error
Removable drive menu this._manager error
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 677228
 
 
Reported: 2012-06-01 15:40 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2012-06-02 09:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
places-menu: Update to work with GNOME Shell git (3.21 KB, patch)
2012-06-01 16:37 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
drive-menu: Update to work with GNOME Shell git (1.22 KB, patch)
2012-06-01 16:37 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-06-01 15:40:54 UTC 
From IRC:

<API> magcius, trying to use removable drive menu I get this error:
<API> JS LOG: Extension "drive-menu@gnome-shell-extensions.gcampax.github.com" had error: TypeError: this._manager is undefined
<API> does that ring any bell? or it is just my environment?
<magcius> API, we removed Main.placesManager upstream

So it seems that this extension is outdated.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-06-01 15:43:33 UTC 
drive-menu and places-menu both use Main.placesManager. Should be extremely easy to fix.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-06-01 16:37:33 UTC 
Created attachment 215448 [details] [review]
places-menu: Update to work with GNOME Shell git
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-01 16:37:36 UTC 
Created attachment 215449 [details] [review]
drive-menu: Update to work with GNOME Shell git
Comment 4 Giovanni Campagna 2012-06-01 17:12:21 UTC 
Review of attachment 215448 [details] [review]:

I was about to say "I hate you!" (for breaking them), but hey, it is easy after all.
Comment 5 Giovanni Campagna 2012-06-01 17:12:45 UTC 
Review of attachment 215449 [details] [review]:

LGTM
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-06-02 09:11:54 UTC 
Attachment 215448 [details] pushed as dca49d6 - places-menu: Update to work with GNOME Shell git
Attachment 215449 [details] pushed as 6e946fe - drive-menu: Update to work with GNOME Shell git