GNOME Bugzilla – Bug 677286
[PATCH] please update to use libmusicbrainz5
Last modified: 2012-10-02 10:43:01 UTC
5 is very similar to 4 (they bumped the version to work around a problem in Debian package versioning I think). Do you want to retain 3 support (presently you support 3-or-4)? sound-juicer is going to drop 3 (see https://bugzilla.gnome.org/show_bug.cgi?id=676749)
Created attachment 215818 [details] [review] Add support for musicbrainz5 Basically a copy of musicbrainz4 support but updated for two API changes. Also fixes: - configure script on saying musicbrainz is supported if v3 headers installed - correctly link against libdiscid for version 4 and 5
(In reply to comment #1) > Created an attachment (id=215818) [details] [review] > Add support for musicbrainz5 This code comes from sound-juicer and needs to be updated there before being added to Rhythmbox.
libmusicbrainz5 support has been merged in sound-juicer, libmusicbrainz4 has been dropped, see bug #676749
I've tested this patch and it worked for me (with multi-disc releases where mb3 did not), but if you're following s-j's lead I guess you might want to strip out mb3 and mb4 support entirely. I could work on such a patch if you like.
*** Bug 679432 has been marked as a duplicate of this bug. ***
Created attachment 222824 [details] [review] audiocd: Port to libmusicbrainz5 And remove support for version 3 and 4 as the service will be broken with those versions.
libmusicbrainz4 should work, only libmb3 will be broken with (at least) multi-disk albums. Are you having with libmb4 as well?
I've just replaced the sj-metadata code with my own thing, which is less code and doesn't involve libmusicbrainz at all.
*** Bug 685271 has been marked as a duplicate of this bug. ***