GNOME Bugzilla – Bug 677142
network: make sure multiple nics are handled ok
Last modified: 2012-11-16 18:54:33 UTC
The nics should be identified in a reasonable way in the menu, and have independent connection status. (Note: this bug is part of a series of bugs I'm filing for handling 'exotic' network constellations)
Uhm... aren't they currently? The menu shows a subsection for each card, with its own switch/status label and connection list. (This is the only kind of 'exotic' hardware that we handle right now. I'd like to see some designer inputs on the other cases before implementing them)
Created attachment 215359 [details] Screenshot of current behaviour
(In reply to comment #1) > Uhm... aren't they currently? I don't know - don't misinterpret these bugs, they are really more test plan tasks for the NetworkManager team than bugs. If things are already working fine, then that is great, and we can just close it after testing it.
Yeah, I think this is FIXED/INVALID; the network menu has had support for multiple nics since the beginning, and it was part of the design
alternatively, as suggested in bug 677143, maybe we should be showing the interface name ("eth0", "eth1") rather than the hardware device name, since many machines with multiple ethernet cards will have multiple *identical* ethernet cards. (The "eth0"s and "eth1"s in Giovanni's screenshot don't count; they're from the connection names, which may not necessarily have the interface name in them depending on how/where they were created. Eg, my primary wired connection is called "Wired connection 1".)
I'm reopening this bug to implement the mockup at https://dl.dropbox.com/u/5031519/gnome-shell/network-menu-lots.png
Created attachment 222840 [details] [review] NetworkMenu: rework multiple NIC support Remove section titles for ethernet and mobile broadband, and replace them with device status items that recognize if multiple devices are installed in the same section, and if so automatically disambiguate.
Review of attachment 222840 [details] [review]: Looks like a good cleanup. Are we in string freeze yet? Commit if so.
(In reply to comment #8) > Review of attachment 222840 [details] [review]: > > Looks like a good cleanup. Are we in string freeze yet? Commit if so. Wait, so fast? This was meant for review by designers first. (Also, it affects UI freeze too, so it needs approval)
*** Bug 681532 has been marked as a duplicate of this bug. ***
discussion of the design changes is also happening on bug 677143 (the control panel version of this bug), so we shouldn't commit either of them until we're sure this is what we're sticking with.
Created attachment 223102 [details] [review] NetworkMenu: rework multiple NIC support Remove section titles for ethernet and mobile broadband, and replace them with device status items that recognize if multiple devices are installed in the same section, and if so automatically disambiguate. This is above bug 682929 and bug 658230.
Created attachment 225715 [details] [review] network: use a new libnm-gtk function to disambiguate device names The control panel will also use this, so this keeps the names in sync between them. This requires libnm-gtk from git master network-manager-applet. And it doesn't incorporate any of the other UI changes in Giovanni's patch or the deps of this bug, so it's not complete as-is.
The control-center has been branched now, so we should look at landing this.
(In reply to comment #14) > The control-center has been branched now, so we should look at landing this. This is about gnome-shell though.
Created attachment 226290 [details] [review] NetworkMenu: rework multiple NIC support Remove section titles for ethernet and mobile broadband, and replace them with device status items that recognize if multiple devices are installed in the same section, and if so automatically disambiguate. ===== This version merges my patch into Giovanni's (and kills some dead code leftover in his). One problem; there are now two Wi-Fi toggle switches, with slightly different behavior. (I get that behavior with just the original patch too.) I figure Giovanni can probably debug this better than I can...
Created attachment 226563 [details] [review] NetworkMenu: rework multiple NIC support Remove section titles for ethernet and mobile broadband, and replace them with device status items that recognize if multiple devices are installed in the same section, and if so automatically disambiguate.
Comment on attachment 226563 [details] [review] NetworkMenu: rework multiple NIC support > if (!this._hardwareEnabled) { >- this.setStatus(_("hardware disabled")); >+ this.setStatus(_("hardware disabled")); > } else if (device && this._softwareEnabled) { > let text = device.getStatusLabel(); > this.setStatus(text); > } else >- this.setStatus(null); >+ this.setStatus(null); accidental? My F18 machine ate itself, so I can't easily test this right now, but it looks right.
should we get this in then, if it looks right ?
Created attachment 229078 [details] [review] NetworkMenu: rework multiple NIC support ==== rebased, and versioned the dependency on libnm-gtk. I discovered a new problem though; if you have more than one wired connection defined in nm-connection-editor, then the different connections show up *above* the "Wired" switch now rather than below it.
Created attachment 229161 [details] [review] this seems to fix the switch/connection-list ordering. (to be squashed)
Review of attachment 229078 [details] [review]: Squash the other one, and let's get this in. There will be time to fix it before 3.8.0 if it breaks again, and the best way to find out is to have it tested.
Attachment 229078 [details] pushed as 490206b - NetworkMenu: rework multiple NIC support