GNOME Bugzilla – Bug 676117
show network device state reason
Last modified: 2013-02-11 17:49:25 UTC
NetworkManager offers for every Device a State and a StateReason. Sometimes it's very helpful to know the DeviceStateReason (eg "SIM Pin Required", "SIM Puk required", ...). There's a huge list with DeviceStateReasons in NetworkManager.h (about 40 entries) and i think for some reasons it would be nice to show the reason directly under the device state in the ui.
Created attachment 214156 [details] [review] network: show device state reasons (Closes:bgo#676117)
(In reply to comment #1) > Created an attachment (id=214156) [details] [review] > network: show device state reasons (Closes:bgo#676117) i edited the network.ui file with glade and glade changed some stuff i didn't want to change. i don't know how to handle this correct. dont use glade? irgnore the changes? fix the changes by hand?
Applied, after making a few UI changes discussed on IRC. Now the ststus reason is a tooltip on the status label... commit 1f24b178ac7fdcbe442f5634c0bb04fcb9b979b6 Author: Thomas Bechtold <thomasbechtold@jpberlin.de> Date: Mon May 14 08:07:06 2012 +0200 network: show device state reasons (Closes:bgo#676117) Signed-off-by: Richard Hughes <richard@hughsie.com>
A tooltip isn't any good on touch devices, and the information should really be available in some other way.
(In reply to comment #4) > A tooltip isn't any good on touch devices, and the information should really be > available in some other way. Agreed. I would add this information to the status string that is already included in the panel. eg. "Disabled - SIM Pin Required"
Comment on attachment 214156 [details] [review] network: show device state reasons (Closes:bgo#676117) That patch was already committed.
Created attachment 235168 [details] [review] network: display "device state reason", and remove duplicate code For disconnected/unavailable devices, show the localized NMDeviceStateReason next to the localized NMDeviceState (and not in the tooltip). Also, move the code to do this into panel-common rather to save some duplication.
Review of attachment 235168 [details] [review]: Looks good overall ::: panels/network/panel-common.h @@ +36,3 @@ const gchar *panel_vpn_state_to_localized_string (NMVPNConnectionState type); +void panel_set_device_status (GtkBuilder *builder, + const gchar *label_name, Line up the parameters if you can.
Attachment 235168 [details] pushed as 15baea4 - network: display "device state reason", and remove duplicate code > Line up the parameters if you can. I didn't do that, since it would have made it inconsistent with the rest of the header.